Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential spent coins issue fix #1994

Merged
merged 1 commit into from Jul 25, 2019

Conversation

@benthecarman
Copy link
Collaborator

commented Jul 23, 2019

We are attempting to remove toRemove.SpenderTransactionId but that should be queued up to remove in the recursive calls. We are removing the coin from out personal list of coins and then should remove the same coin from our mempool.

@lontivero
Copy link
Collaborator

left a comment

@nopara73 please take a look at this one.

@nopara73
Copy link
Collaborator

left a comment

This is a great catch. I'm not sure if this is related to the spent coin issues though.

This coin removal happens at blockchain reorg, double spend or RBF.

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Jul 25, 2019

We decided to give out an additional $100 bug bounty for this fix. Will settle it with the contribution game results.

@nopara73 nopara73 merged commit 411158c into zkSNACKs:master Jul 25, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190723.32 succeeded
Details
Wasabi.Osx #20190723.32 succeeded
Details
Wasabi.Windows #20190723.32 succeeded
Details

@benthecarman benthecarman deleted the benthecarman:potiential_spent_issue_fix branch Jul 25, 2019

@benthecarman

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 25, 2019

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.