Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create const for chars #2011

Merged
merged 1 commit into from Jul 27, 2019

Conversation

@yahiheb
Copy link
Collaborator

commented Jul 24, 2019

No description provided.

@benthecarman

This comment has been minimized.

Copy link
Collaborator

commented Jul 24, 2019

I think it is fine as is, normally you don't do a refactor like this until you have it being used in 3 places

@yahiheb

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 24, 2019

What about it being declared inside the for loop in StoreTests.cs?

@benthecarman

This comment has been minimized.

Copy link
Collaborator

commented Jul 24, 2019

Yeah, it makes sense to move it outside the loop.

@nopara73 nopara73 merged commit e9e9b8e into zkSNACKs:master Jul 27, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190724.63 succeeded
Details
Wasabi.Osx #20190724.63 succeeded
Details
Wasabi.Windows #20190724.63 succeeded
Details

@yahiheb yahiheb deleted the yahiheb:const-chars branch Jul 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.