Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some mapping boilerplate #2023

Merged
merged 11 commits into from Jul 30, 2019

Conversation

@NicolasDorier
Copy link
Collaborator

commented Jul 26, 2019

This remove lot's of unecessary boilerplate by leveraging Newtonsoft for default values.

Additionally, I removed nullable values as it is very easy to shoot yourself in the foot with it.

I think as a followed you should remove your custom extension method Endpoint.ToString and use NBitcoin's Endpoint.ToEndpointString(). I think your version has a bug, and does not render IPv6 properly.

@NicolasDorier

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 26, 2019

@lontivero it is the same you reviewed already but rebased on the latest changes on endpoint.

WalletWasabi.Gui/Config.cs Show resolved Hide resolved
WalletWasabi.Gui/Config.cs Show resolved Hide resolved
@Rmartin1104

This comment has been minimized.

Copy link
Collaborator

commented Jul 26, 2019

Result Status Note
Wasabi GUI exit test Pass Good
Filter downloading tests Pass Good
Context menu and selection tests Pass Good

win10

WalletWasabi.Gui/Config.cs Outdated Show resolved Hide resolved

@NicolasDorier NicolasDorier force-pushed the NicolasDorier:refactor/remove-nullable branch from 45ce8c6 to d7fdaf0 Jul 27, 2019

@NicolasDorier

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 27, 2019

Rebased.

nopara73 and others added 9 commits Jul 29, 2019

@molnard molnard merged commit c6d60d1 into zkSNACKs:master Jul 30, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190730.11 succeeded
Details
Wasabi.Osx #20190730.11 succeeded
Details
Wasabi.Windows #20190730.11 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.