Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetMasterExtKey(password==null) => password = "" #2025

Merged
merged 1 commit into from Jul 27, 2019

Conversation

@DanGould
Copy link
Contributor

commented Jul 26, 2019

This is consistent this KeyManager.CreateNew. Doing so allows for front end ignorance to the implementation of KeyManager. It shouldn't have to handle NullReferenceException or initialize the password to empty string.

GetMasterExtKey(password==null) => password = ""
This is consistent this KeyManager.CreateNew. Doing so allows for front end ignorance to the implementation of KeyManager. It shouldn't have to handle NullReferenceException or initialize the password to empty string.

@nopara73 nopara73 merged commit 737a229 into zkSNACKs:master Jul 27, 2019

3 of 4 checks passed

Wasabi.Linux #20190726.5 failed
Details
CodeFactor No issues found.
Details
Wasabi.Osx #20190726.5 succeeded
Details
Wasabi.Windows #20190726.5 succeeded
Details

@DanGould DanGould deleted the DanGould:patch-1 branch Jul 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.