Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Thread Leak on Windows / Optimize Runtime for running on Desktops #2033

Merged

Conversation

@danwalmsley
Copy link
Collaborator

commented Jul 29, 2019

  1. This fixes the thread leak issue on Windows causing thread count to increase. Overrided in Wasabi, but 0.9 release will have a proper fix too.

  2. .net core has its ThreadPool and Garbage Collector optimized for running on servers. Iv change the MSBuild properties in csproj to correctly optimize for Desktop machines (and apps) these settings are now make .net core behave (GC wise) as it used to on .NET Framework.

I did 2 because a) we are a desktop app, and b) I suspect it might be cause of high cpu usage after running along time (due to heap fragmentation).

@molnard
Copy link
Collaborator

left a comment

Tested the master and this for 10-10 minutes and it works fine. Thread number stays near 30 while with the master it jumps up to 250.

danwalmsley added 2 commits Jul 30, 2019

@nopara73 nopara73 merged commit 0b23264 into zkSNACKs:master Jul 30, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190730.10 succeeded
Details
Wasabi.Osx #20190730.10 succeeded
Details
Wasabi.Windows #20190730.10 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.