Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Brand New wasabiwallet.io ⭐️ #2043

Merged
merged 33 commits into from Aug 8, 2019

Conversation

@mayankchhabra
Copy link
Contributor

commented Aug 1, 2019

This PR redesigns the current website of Wasabi Wallet with a fresh new interface, experience, functionality, and aesthetics. 🎉

All the theme-wide changes, such as the color scheme, typography, spacings, links, buttons, etc are made via a custom Bootstrap 4.3 build using SASS variables, included in the _variables.scss file in WalletWasabi.Backend/wwwroot/css/ directory.

This has two main benefits in particular:

  1. It allows us to carry the same Bootstrap theme across all WW websites, such as the upcoming docs with ease
  2. It removes the need for unnecessary code overwrites in style.css

Custom CSS in style.css has been written in the only cases where there is no default Bootstrap class or structure available to produce the desired outcome, hence the new style.css file is marginally larger, 2KB to be precise, than the current one when compressed.

A test server is live with the up-to-date website code at weareblock.space/wasabi until this PR is merged. Please test it across your devices with different browsers and report any issues, feedback or suggestions.

To-do before merge:

  • Implement dynamic loading of the latest CoinJoin transactions
    CJ transactions are now hardcoded (not live), providing the "proofing" and educating user with live examples, at the same time removing the <iframe> <-> server hack.

  • Implement dynamic loading of the latest release version in the downloads section
    Latest release version will be manually updated at every release, as the download links, signature and guides were updated manually anyway, removing the last bridge between the site and the server.

  • Update textual content

  • Fix any bugs

Closes #1335

@mayankchhabra mayankchhabra marked this pull request as ready for review Aug 1, 2019

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator

commented Aug 1, 2019

Oh this looks so good!! Thank you very much for this @mayankchhabra ❤️!!

A couple things:

  • at the bottom the Press Kit is split awkwardly in two lines when the window is at about 60% of screen width
  • It would be great to link to the new docs.wasabiwallet.io website in the top nav bar for dojo and faq or just docs in general, but the link is only ready when @nopara73 does the CNAME entry.
  • the bottom FAQ is a good selection of questions - and below it should link to the new docs website.
  • the coin join link should probably go to Blockstream.info, or what other block explorer do you suggest?
@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator

commented Aug 1, 2019

May I suggest to make the necessary ToDos to release this new website and the new documentation a short term priority? It does not have to be perfect, we can always push fixes and improvements.

I would really really like if we can push this on August 1st to celebrate #UASF.

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Aug 1, 2019

I would really really like if we can push this on August 1st to celebrate #UASF.

@MaxHillebrand Wasabi's first beta release was also on August 1:)

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Aug 1, 2019

@mayankchhabra This is great! Are you looking for review or not yet?

As I see it, one of your main issue is/will be how to show the recent coinjoins properly. Maybe we could remove that part altogether, because at this point nobody will be convinced that Wasabi works based on that data, which was the reason why it got there in the first place, but today there's enough press about Wasabi for this to not be a questionable anymore.

The other issue which you will encounter is getting the download version from code. However I think it's fine hardcoded how you did it, I'll be ok with updating it by hand, since I have to update the links anyway.

If we remove these two things then there won't be any more link between the server and the website anymore, which is good removing these hacks.

@mayankchhabra

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

Thanks, Max and Adam!

Alright then, seems like August 1 really is the day with the universal consensus around it, haha!
(edit: turns out it wasn't, the universe wanted to take it easy)

Working on your suggestions, Max.

Adam, yes let's get this reviewed.

because at this point nobody will be convinced that Wasabi works based on that data, which was the reason why it got there in the first place, but there's enough press for this to not be a questionable anymore

ACK that there is no proofing required anymore as there is enough press-coverage and social-proofing via twitter, etc. Also, with the current back-end code, it's not viable to load up an <iframe> with duplicate CSS files to just show the transactions.

However, it's nice to see it live in action, as that gives the sense of how it looks in real life, plus educates users with live, real-life examples. What we can do is, for now, hard code some of the CJ txs done by Wasabi, including the famous 100 participant tx, and then work on the backend endpoint later on for fetching live txs.

Regarding the release version

I'll be ok with updating it by hand, since I have to update the links anyway.

ACK! Makes sense

Lastly, let's get the textual content for the CJ paragraph and FAQs in place so we can get this up!

@mayankchhabra

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

Ready for review and merge @nopara73 @MaxHillebrand 🚀

@MaxHillebrand
Copy link
Collaborator

left a comment

this is a great upgrade to the website!! thank you very much @mayankchhabra!! ❤️

always room for improvements, especially with some wording of the text - but I think this should evolve in several PRs, and not all in this one.

I guess the only thing missing is:

  • @nopara73 please add CNAME registry of docs.wasabiwallet.io to zksnacks.github.io, then the FAQ will be published as well - and we can merge this PR without any broken lings.
@mayankchhabra

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

Thanks, @MaxHillebrand, @nopara73, and @dennisreimann for your feedback! 🙌

Pushed an update:

  • Fixed docs link in the navbar
  • Rectified important w3c validation errors in index.html

@nopara73 VS 2017 has lousy IntelliSense when it comes to HTML/CSS validation. As you can see, most of the validation errors are in-fact from bootstrap.css.

The general rule of thumb is that if the browsers render everything as you expect, just go with it. Browsers are updated with new CSS properties quite often with their every release, while VS waits for an official CSS release that might take months if not years. So I'd say we can comfortably ignore the validation errors and go forward! 🚀

A couple of things that I'd like to suggest before we merge:

  • Having the word "Bitcoin" in all title tags. Right now it is Wasabi Wallet - Unfairly Private, we can change it to Wallet Wallet - An unfairly private wallet for Bitcoin. Instantly gets the idea across, plus helps in SEO.

  • Changing the heading of the website from "reclaim your privacy now" back to "An unfairly private wallet for Bitcoin". Same reason, the former is a strong CTA slogan, the latter is a product description. Under "An unfairly private wallet for Bitcoin" we can write "reclaim your privacy now" as the tagline to push the narrative forward with the description and CTA duo complementing each other.

  • The heading of the website on mobile changes from "reclaim your privacy now" to "unfairly private". I'm not sure if that was intentional @nopara73 or you accidentally changed it while changing the title tags...

@MaxHillebrand
Copy link
Collaborator

left a comment

Great!
One more thing I noticed:

  • Couldn’t find your question? Read our extended FAQs in docs > should be Couldn’t find your question? Read our extended FAQs in **the documentation** >

And a general question, this PR would merge the new website in the main zkSnacks/WalletWasabi repository, yet this clutters the code, and it is a hindrance for fast and reckless iteration of the website in the future. Should we instead host this in the new zkSnacks/WasabiDoc repository? I think it might be better to separate the website [both the main and the docs] from the wallet and backend code...

@mayankchhabra

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

Read our extended FAQs in the documentation

We can change that, but the text becomes really long as a single link itself... That's why it was trimmed to keep it short. Perhaps, we can do <no link>Couldn't find your question?</no link> <link>Read extended FAQs in the documentation</link>

Edit: Pushed (live)

Regarding creating a separate repo for the hosting, I do agree that the website would be better suited to have its own repo, more so because we do not have a client-server link anymore that utilizes the Wasabi.Backend APIs. However, I think instead of merging the website with the docs repo, it's better to create a WasabiWebsite repo for more organized, productive and efficient management.

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Aug 6, 2019

Having the word "Bitcoin" in all title tags. Right now it is Wasabi Wallet - Unfairly Private, we can change it to Wallet Wallet - An unfairly private wallet for Bitcoin. Instantly gets the idea across, plus helps in SEO.

Concept ACK, but implementation NACK. The problem with the "An unfairly private wallet for Bitcoin" is that "unfairly private" is dubious enough if makes grammatical sense. It's a reference to Jihan calling segwit "unfairly cheap" so we should use it as is or just change it altogether.

Changing the heading of the website from "reclaim your privacy now" back to "An unfairly private wallet for Bitcoin". Same reason, the former is a strong CTA slogan, the latter is a product description. Under "An unfairly private wallet for Bitcoin" we can write "reclaim your privacy now" as the tagline to push the narrative forward with the description and CTA duo complementing each other.

Same comment.

The heading of the website on mobile changes from "reclaim your privacy now" to "unfairly private". I'm not sure if that was intentional @nopara73 or you accidentally changed it while changing the title tags...

Yes, it looked better when I restored the original quote.

Summary

I don't have a good idea how to keep Bitcoin in the texts. "unfairly private" should be kept intact, only change it if there's a better text to put there.

@MaxHillebrand

And a general question, this PR would merge the new website in the main zkSnacks/WalletWasabi repository, yet this clutters the code, and it is a hindrance for fast and reckless iteration of the website in the future. Should we instead host this in the new zkSnacks/WasabiDoc repository?

We can't. The Tor website must be ran from the server, because that's the same url the clients are talking to.

@nopara73
Copy link
Collaborator

left a comment

ACK. Everything looks good now.

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Aug 6, 2019

I'd love one more review on this. Anyone could do it just check the testnet website so no need to set up local dev environment: https://wasabiwallet.co/

Maybe @benthecarman?

@mayankchhabra

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2019

Great! @nopara73 can you please push the latest code to the testnet server? The formatting for the docs link underneath the FAQ has been tweaked a bit.


var content = File.ReadAllText(path);

content = content.Replace("http://wasabiukrxmkdgve5kynjztuovbg43uxcbcxn6y2okcrsg7gb6jdmbad.onion", "https://wasabiwallet.io", StringComparison.Ordinal);

This comment has been minimized.

Copy link
@benthecarman

benthecarman Aug 6, 2019

Collaborator

The onion link might be able to be moved to a variable, it is also linked in the About view page.

@benthecarman

This comment has been minimized.

Copy link
Collaborator

commented Aug 6, 2019

@benthecarman

This comment has been minimized.

Copy link
Collaborator

commented Aug 6, 2019

The build from source link points to the repo, it would be better if it pointed to https://github.com/zkSNACKs/WalletWasabi#build-from-source-code

@benthecarman

This comment has been minimized.

Copy link
Collaborator

commented Aug 6, 2019

The free and open source button sends to the repo, maybe consider changing it to https://docs.wasabiwallet.io/why-wasabi/10Commandments.html#_2-verify-the-integrity-of-your-software

@benthecarman
Copy link
Collaborator

left a comment

Looks really good, just a few changes that I think would improve it

@mayankchhabra mayankchhabra dismissed stale reviews from MaxHillebrand and nopara73 via 773b574 Aug 6, 2019

@mayankchhabra

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2019

Good feedback @benthecarman, thank you! The links have been changed. Waiting for @nopara73 to redeploy on testnet for the final testing. 🚀

@benthecarman

This comment has been minimized.

Copy link
Collaborator

commented Aug 7, 2019

The "Further reading: [Reddit] Combining Mixed Coins" and "Further reading: Chaumian Coinjoin" just go to wasabiwallet.io

@mayankchhabra

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2019

Good find @benthecarman 🔍
Fixed the links!

@nopara73 nopara73 merged commit a7b99d8 into zkSNACKs:master Aug 8, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190807.6 succeeded
Details
Wasabi.Osx #20190807.6 succeeded
Details
Wasabi.Windows #20190807.6 succeeded
Details
@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Aug 8, 2019

Thank you guys, great work, this may have been the first large PR I didn't feel the need to micromanage :)

I deployed it to the testnet. We'll deploy it to the mainnet with the next release.

https://wasabiwallet.co/

@yahiheb

This comment has been minimized.

Copy link
Collaborator

commented Aug 8, 2019

Great work guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.