Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nameof instead of magic strings (Backend project) #2072

Merged
merged 2 commits into from Aug 12, 2019

Conversation

@yahiheb
Copy link
Collaborator

commented Aug 4, 2019

No description provided.

@lontivero
Copy link
Collaborator

left a comment

This PR contains changes that I would like to merge and others that I think are not desired, specifically those that make reference to errors about json request fields. If those few changes are reverted then this PR will be merged.

@yahiheb

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 8, 2019

I honestly don't know which ones should be reverted can you please point them out.

@nopara73
Copy link
Collaborator

left a comment

LGTM, I don't understand @lontivero's "Invalid uniqueId provided" comments.

@lontivero

This comment has been minimized.

Copy link
Collaborator

commented Aug 12, 2019

Me neither. It seems I copied and pasted something wrong.

@lontivero lontivero merged commit 953bc77 into zkSNACKs:master Aug 12, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190810.2 succeeded
Details
Wasabi.Osx #20190810.2 succeeded
Details
Wasabi.Windows #20190810.2 succeeded
Details

@yahiheb yahiheb deleted the yahiheb:nameof-backend branch Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.