Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary pragma warnings, commas, and use PascalCase with e… #2083

Merged

Conversation

@yahiheb
Copy link
Collaborator

commented Aug 6, 2019

…numerators

@lontivero
Copy link
Collaborator

left a comment

This PR is breaks the Tor communication.

@yahiheb

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 8, 2019

@lontivero Is that because I changed http to Http and https to Https?

@lontivero

This comment has been minimized.

Copy link
Collaborator

commented Aug 8, 2019

yes, take a look how it is used:

foreach (UriScheme scheme in Enum.GetValues(typeof(UriScheme)))

yahiheb added 2 commits Aug 8, 2019
@nopara73
Copy link
Collaborator

left a comment

ACK with one question.

WalletWasabi/Http/Models/UriScheme.cs Show resolved Hide resolved

@nopara73 nopara73 merged commit 93db7ac into zkSNACKs:master Aug 9, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190808.13 succeeded
Details
Wasabi.Osx #20190808.13 succeeded
Details
Wasabi.Windows #20190808.13 succeeded
Details

@yahiheb yahiheb deleted the yahiheb:pragma-warning-commas-capitalization branch Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.