Remove Replaced transactions from cache #2088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yahiheb
reviewed
Aug 7, 2019
benthecarman
previously approved these changes
Aug 7, 2019
nopara73
previously approved these changes
Aug 9, 2019
lontivero
force-pushed
the
Fix/Remove-Transaction-From-Chache
branch
from
90b7309
to
ddb3432
Compare
|
Done. |
benthecarman
previously approved these changes
Aug 9, 2019
MaxHillebrand
previously approved these changes
Aug 10, 2019
|
Oh, wanted to merge it, but there's still a conflict. |
lontivero
dismissed stale reviews from MaxHillebrand and benthecarman
via
26f56c6
lontivero
force-pushed
the
Fix/Remove-Transaction-From-Chache
branch
from
ddb3432
to
26f56c6
Compare
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case a transaction is replaced (RBF) by other one or when there is a chain reorg the coins created by those transactions are removed from the Coins list. The transactions that created those coins has to be removed too.