Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly check for regtest network #2090

Merged
merged 1 commit into from Aug 9, 2019

Conversation

@benthecarman
Copy link
Collaborator

commented Aug 7, 2019

We should explicitly check that it is the regtest network, future networks could be added, segnet for example.

@lontivero
Copy link
Collaborator

left a comment

Yes, this is good. Thanks @benthecarman

@nopara73
Copy link
Collaborator

left a comment

Yes, it's the better practice.

@nopara73 nopara73 merged commit 40be866 into zkSNACKs:master Aug 9, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190807.11 succeeded
Details
Wasabi.Osx #20190807.11 succeeded
Details
Wasabi.Windows #20190807.11 succeeded
Details

@benthecarman benthecarman deleted the benthecarman:force_check_regtest branch Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.