Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSX Clipboard handling fixes #2100

Merged
merged 33 commits into from Aug 16, 2019
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
066f42a
Change the logic, add more warning.
molnard Aug 9, 2019
27450ea
Tool to reproduce the cut password and tests.
molnard Aug 9, 2019
7d852d9
Clean up the Enter logic of Passwordbox
molnard Aug 9, 2019
5c37303
Add Avalonia directly so shell will use that
molnard Aug 12, 2019
b5ff074
Add pw compatibility.
molnard Aug 12, 2019
d0f8fb3
Better logic.
molnard Aug 12, 2019
ce02e0a
Add Avalonia.Native
molnard Aug 12, 2019
6398f0a
Add UI warn messages.
molnard Aug 12, 2019
7fcfacf
Fix display error of warn messages
molnard Aug 12, 2019
d8acef9
Code clean.
molnard Aug 12, 2019
0f31d07
Add PasswordTests to CI
molnard Aug 13, 2019
fc7c6ae
Remove unrequired Ref to Avalonia
molnard Aug 13, 2019
6ff65c6
Code clean.
molnard Aug 13, 2019
69d2475
Encoding.Default go home.
molnard Aug 13, 2019
b355f11
Update WalletWasabi/Helpers/Constants.cs
molnard Aug 13, 2019
ad2fe89
Add Avalonia Clipboard tests
molnard Aug 13, 2019
d74a560
Try to fix CI
molnard Aug 13, 2019
cb60045
Removed AvaloniaTests - cannot make it work.
molnard Aug 13, 2019
197cf83
Add OS selectivity
molnard Aug 14, 2019
d7fde2d
Code refactor - pw separation
molnard Aug 15, 2019
fe1dba6
Add functions to Daemon
molnard Aug 15, 2019
5a663a4
Merge branch 'master' into macpwfix
molnard Aug 15, 2019
3664f21
Remove Avalonia.Native
molnard Aug 15, 2019
10472f8
Overfee want overwritten fix
molnard Aug 16, 2019
8a26e10
Add readonly.
molnard Aug 16, 2019
6a758ee
Grammar.
molnard Aug 16, 2019
9258494
Add test.
molnard Aug 16, 2019
83e3d7f
Merge branch 'master' into macpwfix
molnard Aug 16, 2019
3e1d558
Remove GUI from tests.
molnard Aug 16, 2019
d79f64b
Guard when generating wallet.
molnard Aug 16, 2019
53d33cf
Add tests.
molnard Aug 16, 2019
392615a
Use PasswordHelper.IsTooLong.
molnard Aug 16, 2019
ca5099b
Refactor Enter on pwbox.
molnard Aug 16, 2019
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Add Avalonia.Native

  • Loading branch information...
molnard committed Aug 12, 2019
commit ce02e0a9bcebfb2eb60d93d7adb609f18c143fae
@@ -65,6 +65,7 @@

<ItemGroup>
<PackageReference Include="Avalonia" Version="0.8.2" />
This conversation was marked as resolved by molnard

This comment has been minimized.

Copy link
@lontivero

lontivero Aug 13, 2019

Collaborator

Two new packages? Why? What do they contain?

This comment has been minimized.

Copy link
@danwalmsley

danwalmsley Aug 13, 2019

Collaborator

This overrides Avalonia to 0.8.2 (since they are binary compatible)

We actually only need Avalonia.Native, since the only code change was in Avalonia.Native.

Avalonia.Native is the OSX backend.

In 0.9 release it will be a requirement for the xamlil compiler that we reference Avalonia.Desktop only from the csproj.

This comment has been minimized.

Copy link
@nopara73

nopara73 Aug 13, 2019

Collaborator

Could we keep only AvalonStudio.Shell? I don't like the direction this is going.

<PackageReference Include="Avalonia.Native" Version="0.8.2" />
This conversation was marked as resolved by molnard

This comment has been minimized.

Copy link
@nopara73

nopara73 Aug 13, 2019

Collaborator

This is still not resolved.

This comment has been minimized.

Copy link
@molnard

molnard Aug 14, 2019

Author Collaborator

AvalonStudio.Shell references this library as well, so basically there is no new reference.

With Avalonia 0.9 we will need to do the same thing. Both Shell and Avalonia will be referenced.

This comment has been minimized.

Copy link
@nopara73

nopara73 Aug 14, 2019

Collaborator

That's not what we agreed on with @danwalmsley. We use everything Avalonia through the shell.

This comment has been minimized.

Copy link
@molnard

molnard Aug 16, 2019

Author Collaborator

Solved!

<PackageReference Include="AvalonStudio.Shell" Version="0.8.1" />
</ItemGroup>

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.