Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xaml fixes #2109

Merged
merged 6 commits into from Aug 12, 2019

Conversation

@danwalmsley
Copy link
Collaborator

commented Aug 11, 2019

Really this PR is about putting in x:Class directives and fixing any bad Xaml that will crash the 0.9 Avalonias Xaml compiler.

x:Class is required so that the xaml compiler can resolve types and properties.

Id like to merge this to prevent a huge mess of merge conflicts when we do the 0.9 update.

It also makes some classes and properties public, these will cause crashes when we update.

@danwalmsley danwalmsley referenced this pull request Aug 11, 2019
0 of 2 tasks complete
@lontivero
Copy link
Collaborator

left a comment

@danwalmsley it looks good. I am going to test it tomorrow. Could you remove the trailing spaces/tabs, please?

@danwalmsley

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 11, 2019

@danwalmsley it looks good. I am going to test it tomorrow. Could you remove the trailing spaces/tabs, please?

sure thing... done

@nopara73
Copy link
Collaborator

left a comment

untested LGTM. No behavior changes had been made.

@lontivero lontivero merged commit 0c356fe into zkSNACKs:master Aug 12, 2019

3 of 4 checks passed

Wasabi.Windows #20190811.7 failed
Details
CodeFactor No issues found.
Details
Wasabi.Linux #20190811.7 succeeded
Details
Wasabi.Osx #20190811.7 succeeded
Details

@danwalmsley danwalmsley deleted the danwalmsley:xaml-fixes branch Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.