Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout of GetXpubAsync #2120

Merged
merged 2 commits into from Aug 14, 2019
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -108,7 +108,7 @@ public static async Task<ExtPubKey> GetXpubAsync(HardwareWalletInfo hardwareWall
{
var networkString = Network == Network.Main ? "" : "--testnet ";
JToken jtok = null;
using (CancellationTokenSource cts = new CancellationTokenSource(TimeSpan.FromSeconds(60)))
using (CancellationTokenSource cts = new CancellationTokenSource(TimeSpan.FromMinutes(3)))
{
jtok = await SendCommandAsync($"{networkString}--device-type \"{hardwareWalletInfo.Type.ToString().ToLowerInvariant()}\" --device-path \"{hardwareWalletInfo.Path}\" getxpub m/84h/0h/0h", cts.Token);
}
@@ -205,7 +205,7 @@ public static async Task<JToken> SendCommandAsync(string command, CancellationTo
}
catch (Exception ex) when (ex is OperationCanceledException || ex is TaskCanceledException || ex is TimeoutException)
{
throw new TimeoutException("Timeout occurred during the hwi operation.", ex);
throw new TimeoutException($"Timeout occurred during the hwi operation{command}.", ex);

This comment has been minimized.

Copy link
@benthecarman

benthecarman Aug 14, 2019

Collaborator

Need a space after "operation"

}
}

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.