Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetOrDownloadBlockAsync Refactor #2123

Merged
merged 6 commits into from Aug 20, 2019

Conversation

@benthecarman
Copy link
Collaborator

commented Aug 15, 2019

No description provided.

//if (!peerServices.HasFlag(NodeServices.Network) && !peerServices.HasFlag(NodeServices.NODE_NETWORK_LIMITED))
//{
// throw new InvalidOperationException($"Wasabi cannot use the local node because it does not provide blocks.");
//}

This comment has been minimized.

Copy link
@yahiheb

yahiheb Aug 16, 2019

Collaborator

Should this commented code be removed?

This comment has been minimized.

Copy link
@benthecarman

benthecarman Aug 16, 2019

Author Collaborator

Was there beforehand, most of this is just copy-pasting

This comment has been minimized.

Copy link
@nopara73

nopara73 Aug 18, 2019

Collaborator

It can go I think. @lontivero ?

WalletWasabi/Services/WalletService.cs Outdated Show resolved Hide resolved
WalletWasabi/Services/WalletService.cs Show resolved Hide resolved
WalletWasabi/Services/WalletService.cs Outdated Show resolved Hide resolved
WalletWasabi/Services/WalletService.cs Show resolved Hide resolved
WalletWasabi/Services/WalletService.cs Outdated Show resolved Hide resolved
@lontivero

This comment has been minimized.

Copy link
Collaborator

commented Aug 16, 2019

It re-downloads all the blocks again and again.

@lontivero
Copy link
Collaborator

left a comment

I didn't see the latest two commits. Re-tested. Works okay. In case of broken block files it logs correctly and re-download the broken block okay.

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Aug 18, 2019

It's really hard to review. @benthecarman did you change any of the original logic here?

@benthecarman

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 18, 2019

Only logic change is here https://github.com/zkSNACKs/WalletWasabi/pull/2123/files#diff-0a80ca357eb532ff3ed358fb4c8caae1R610

Instead of comparing every file name in the directory, I changed it to just search for the exact file

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Aug 18, 2019

Instead of comparing every file name in the directory, I changed it to just search for the exact file

Makes sense:)

@nopara73
Copy link
Collaborator

left a comment

Waiting for @lontivero to decide on this and can be merged:
#2123 (comment)

@benthecarman benthecarman dismissed stale reviews from nopara73 and lontivero via f13d1d9 Aug 20, 2019

@lontivero lontivero merged commit afa6ed1 into zkSNACKs:master Aug 20, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190820.2 succeeded
Details
Wasabi.Osx #20190820.2 succeeded
Details
Wasabi.Windows #20190820.2 succeeded
Details

@benthecarman benthecarman deleted the benthecarman:godbar branch Aug 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.