Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WalletService InitializeAsync Refactor #2128

Merged
merged 2 commits into from Aug 19, 2019

Conversation

@benthecarman
Copy link
Collaborator

commented Aug 17, 2019

No description provided.

@nopara73
Copy link
Collaborator

left a comment

UnconfirmedTransactionsInitialized = true; is in the wrong finally block, the encapsulating try finally has disappeared. Other than that, all looks good.

@lontivero
Copy link
Collaborator

left a comment

Reviewed. Tested. Works okay.

@lontivero lontivero merged commit a037c09 into zkSNACKs:master Aug 19, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190818.7 succeeded
Details
Wasabi.Osx #20190818.7 succeeded
Details
Wasabi.Windows #20190818.7 succeeded
Details

@benthecarman benthecarman deleted the benthecarman:wsinit branch Aug 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.