Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monospaced Embedded Font #2136

Merged
merged 7 commits into from Aug 26, 2019

Conversation

@jmacato
Copy link
Collaborator

commented Aug 20, 2019

This PR adds & embeds a monospaced font for more visual clarity on labels like addresses, pub/priv key, etc.

Pre-requisite for future work in #2118

jmacato added 2 commits Aug 20, 2019
Embed a font for numerical fields and other monospaced styled fields.
Embedded Font (Inconsolata) is published under the SIL Open Font License (OFL) which allows for Embedding.
Fix Receive tab address label expanding by setting its vertical align…
…ment to `Top`.

Add more labels to have monospaced font.

@jmacato jmacato marked this pull request as ready for review Aug 20, 2019

@benthecarman

This comment has been minimized.

Copy link
Collaborator

commented Aug 20, 2019

Could you add the monospaceFont class to the send tab's address textbox?

@benthecarman benthecarman added the UX label Aug 20, 2019

@jmacato

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 20, 2019

@benthecarman Yep, been thinking whether to add that to both address and label textbox too. Guess it wouldn't hurt to try :D

@benthecarman
Copy link
Collaborator

left a comment

I think the Label textbox shouldn't have it, all the other places the label appears it is using the default font.

Otherwise, ACK, and tested

@nopara73
Copy link
Collaborator

left a comment

Tested ACK. Code looks good, too.

@lontivero

This comment has been minimized.

Copy link
Collaborator

commented Aug 21, 2019

It doesn't look great in my linux machine. The font size is smaller and the color is a bit darker. This makes the info harder to read. Can that be improved?

image

@jmacato

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 21, 2019

@lontivero Perhaps we could increase Font size? Especially on CoinListView

@danwalmsley

This comment has been minimized.

Copy link
Collaborator

commented Aug 21, 2019

@jmacato suggestion, the labels right align them and use normal font.

Use monospaced left aligned only for the values.

@molnard

This comment has been minimized.

Copy link
Collaborator

commented Aug 22, 2019

We should use it for Amounts on History Tab as it will align the +/-.
image

@molnard

This comment has been minimized.

Copy link
Collaborator

commented Aug 22, 2019

Checked on win and mac it looks the same. As Lucas said it was smaller:

image

@jmacato jmacato dismissed stale reviews from nopara73 and benthecarman via 23bc27c Aug 23, 2019

@molnard

This comment has been minimized.

Copy link
Collaborator

commented Aug 23, 2019

This looks good
image

@molnard

This comment has been minimized.

Copy link
Collaborator

commented Aug 23, 2019

Can you use the same font size which was used before regarding the amount and clusters? It is larger now.

image

@lontivero
Copy link
Collaborator

left a comment

In this latest version the font size looks very similar to the one we are currently using. The difference in the font color is simply because the row selection highlight.

@molnard molnard merged commit 2214cb8 into zkSNACKs:master Aug 26, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190823.25 succeeded
Details
Wasabi.Osx #20190823.25 succeeded
Details
Wasabi.Windows #20190823.25 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.