Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply async best practices to Tor library #2137

merged 6 commits into from Aug 21, 2019


Copy link

commented Aug 20, 2019

This PR has 3 changes in 3 commits. They can be merged altogether or cherry-picked separately.

In commits 0fac56e and 950df84 I made sure we use the non-blocking version of ReadToEnd, which is ReadToEndAsync.

In commit 6bb7d25 I made sure the Tor library is consistently using ConfigureAwait(false), since it does not have to synchronize back the context ever. This may result in some performance increase.

This PR follows the same pattern as the HWI PR does. I'm ConfigureAwait(false)-ing there, too: #1905

Since we decided that using ConfigureAwait(false) on the library project makes sense, but too risky to do this system wide, it's a reasonable way to do this for subsystems first.

nopara73 added 3 commits Aug 20, 2019
nopara73 added 3 commits Aug 21, 2019
Copy link

left a comment

LGTM and behaves well.

@nopara73 nopara73 merged commit 9ded0dd into zkSNACKs:master Aug 21, 2019

4 checks passed

CodeFactor No issues found.
Wasabi.Linux #20190821.6 succeeded
Wasabi.Osx #20190821.6 succeeded
Wasabi.Windows #20190821.6 succeeded

@nopara73 nopara73 deleted the nopara73:ReadToEnd branch Aug 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.