Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused member #2148

Merged
merged 1 commit into from Aug 23, 2019

Conversation

@yahiheb
Copy link
Collaborator

commented Aug 23, 2019

Maybe it should used somewhere, I don't know.

@benthecarman

This comment has been minimized.

Copy link
Collaborator

commented Aug 23, 2019

If we are deleting this function, can probably delete the SuccessMessage variable as well

@yahiheb

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 23, 2019

But SuccessMessage is used elsewhere.

@benthecarman

This comment has been minimized.

Copy link
Collaborator

commented Aug 23, 2019

But SuccessMessage is used elsewhere.

Yes, just checked it is used here, maybe it would be better to use SetSucessMessage there instead.

@lontivero
Copy link
Collaborator

left a comment

Trivial.

@lontivero lontivero merged commit a170cb4 into zkSNACKs:master Aug 23, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190823.1 succeeded
Details
Wasabi.Osx #20190823.1 succeeded
Details
Wasabi.Windows #20190823.1 succeeded
Details

@yahiheb yahiheb deleted the yahiheb:unused-member branch Aug 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.