Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nameof and add . when necessary (WalletWasabi project) #2166

Merged
merged 2 commits into from Aug 25, 2019

Conversation

@yahiheb
Copy link
Collaborator

commented Aug 24, 2019

No description provided.

@@ -36,7 +36,7 @@ internal ErrorCorrectionBlocks GetECBlocksByLevel(ErrorCorrectionLevel ECLevel)
return ECBlocks[3];

default:
throw new System.ArgumentOutOfRangeException("Invalide ErrorCorrectionLevel");
throw new System.ArgumentOutOfRangeException($"Invalide {nameof(ErrorCorrectionLevel)}.");

This comment has been minimized.

Copy link
@benthecarman

benthecarman Aug 24, 2019

Collaborator

Invalide

Typo here, may as well fix

This comment has been minimized.

Copy link
@yahiheb

yahiheb Aug 24, 2019

Author Collaborator

I didn't get that.

This comment has been minimized.

Copy link
@benthecarman

benthecarman Aug 24, 2019

Collaborator

Change Invalide -> Invalid

This comment has been minimized.

Copy link
@yahiheb

yahiheb Aug 24, 2019

Author Collaborator

Thanks

@benthecarman
Copy link
Collaborator

left a comment

LGTM after the typo fix

@lontivero lontivero merged commit 12d43c3 into zkSNACKs:master Aug 25, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190824.7 succeeded
Details
Wasabi.Osx #20190824.7 succeeded
Details
Wasabi.Windows #20190824.7 succeeded
Details

@yahiheb yahiheb deleted the yahiheb:nameof-walletwasabi branch Aug 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.