Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disallowed fields rule #2169

Merged
merged 1 commit into from Aug 25, 2019

Conversation

@yahiheb
Copy link
Collaborator

commented Aug 25, 2019

No description provided.

@lontivero

This comment has been minimized.

Copy link
Collaborator

commented Aug 25, 2019

This needs an explanation. I don't understand what this does and also need to know how to test it.

@lontivero lontivero closed this Aug 25, 2019

@lontivero lontivero reopened this Aug 25, 2019

@yahiheb

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 25, 2019

Fields must always be private except constant and static read-only fields. (source)
This rule prevents us from creating public, protected internal, protected, private protected fields which are not recommended.
To test this create a public int field and give it any name, a violation of this rule will occur (except when you name your field like this ____RULE_VIOLATION____FIELDNAME____RULE_VIOLATION____)

@lontivero lontivero merged commit 9b8599f into zkSNACKs:master Aug 25, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190825.6 succeeded
Details
Wasabi.Osx #20190825.6 succeeded
Details
Wasabi.Windows #20190825.6 succeeded
Details

@yahiheb yahiheb deleted the yahiheb:dissallowed-fields-rule branch Aug 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.