Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmation Expected Text moved to FeeTarget Converter #2177

Merged
merged 2 commits into from Aug 27, 2019

Conversation

@benthecarman
Copy link
Collaborator

commented Aug 26, 2019

MVVM stuff

@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Aug 26, 2019

It's a very good PR. untested ACK

@lontivero

This comment has been minimized.

Copy link
Collaborator

commented Aug 27, 2019

Btw, I've tested it and works okay.

@nopara73 nopara73 merged commit ebf47b8 into zkSNACKs:master Aug 27, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190827.3 succeeded
Details
Wasabi.Osx #20190827.3 succeeded
Details
Wasabi.Windows #20190827.3 succeeded
Details

@benthecarman benthecarman deleted the benthecarman:mvvm_conf_expected branch Aug 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.