Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code (remove redundant check) #2180

Merged
merged 2 commits into from Sep 3, 2019

Conversation

@yahiheb
Copy link
Collaborator

commented Aug 26, 2019

As discussed with @nopara73 in #2161

@nopara73
Copy link
Collaborator

left a comment

This is ugly. Is it possible to disable unreachable code detection on file level instead?

@yahiheb

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 27, 2019

Yes it is possible.

@yahiheb yahiheb dismissed stale reviews from molnard and benthecarman via e70d412 Sep 1, 2019

@lontivero lontivero merged commit 2e6730d into zkSNACKs:master Sep 3, 2019

4 checks passed

CodeFactor No issues found.
Details
Wasabi.Linux #20190901.9 succeeded
Details
Wasabi.Osx #20190901.9 succeeded
Details
Wasabi.Windows #20190901.9 succeeded
Details

@yahiheb yahiheb deleted the yahiheb:code-refactoring branch Sep 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.