Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Chinese character masking from PasswordBox #2187

Merged
merged 28 commits into from Sep 9, 2019
Merged
Changes from 21 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
125dcd6
Add new pwbox
molnard Aug 28, 2019
8cc53f3
Finalize passwordbox UI and logic
molnard Aug 29, 2019
a23c595
Add .ObserveOn(RxApp.MainThreadScheduler)
molnard Aug 29, 2019
9ed7efb
Rename the control to TogglePasswordBox
molnard Aug 29, 2019
2a956e6
Rename control to TogglePasswordBox
molnard Aug 29, 2019
c4f62e8
Set default values.
molnard Aug 29, 2019
8cb8694
Remove NoparaPasswordBox.
molnard Aug 29, 2019
0ffd3a4
Codefactor
molnard Aug 29, 2019
9d4606c
Add validation methods
molnard Aug 29, 2019
1383553
Replace detecting traling \n with behavior.
molnard Aug 29, 2019
cee453a
We are not fixing anything when generating a wallet just throw except…
molnard Aug 29, 2019
ff9b7a0
Merge branch 'master' into lucaspwbox
molnard Aug 29, 2019
4ea1b0a
Always use Guard.Correct before verifying pw.
molnard Aug 29, 2019
d6e6cbf
Add compatiblity pw mode to CJ
molnard Aug 29, 2019
4120ef6
It is not unconventional anymore.
molnard Aug 29, 2019
a4059e7
Fix the tests.
molnard Aug 29, 2019
74d55cb
Codeformat
molnard Aug 29, 2019
b41aa57
Change masking char.
molnard Aug 30, 2019
e52335a
Fix warn message and add canGenerate.
molnard Sep 3, 2019
7462451
Merge branch 'master' into lucaspwbox
molnard Sep 3, 2019
cfbd877
Set proper width for pwboxes
molnard Sep 3, 2019
ccde4d0
Update WalletWasabi.Gui/Tabs/WalletManager/GenerateWalletViewModel.cs
molnard Sep 4, 2019
71ec69b
Update WalletWasabi.Gui/Controls/WalletExplorer/CoinJoinTabView.xaml
molnard Sep 4, 2019
a72af73
Update WalletWasabi.Gui/Controls/TogglePasswordBox.xaml
molnard Sep 4, 2019
bbb4d86
Update WalletWasabi.Gui/Controls/TogglePasswordBox.xaml
molnard Sep 4, 2019
57055f3
Update WalletWasabi.Gui/Controls/TogglePasswordBox.xaml
molnard Sep 4, 2019
43248a2
Code clean.
molnard Sep 4, 2019
803699c
Update WalletWasabi.Gui/Tabs/WalletManager/GenerateWalletViewModel.cs
molnard Sep 4, 2019
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -19,7 +19,7 @@
<StyleInclude Source="resm:WalletWasabi.Gui.Controls.GroupBox.xaml?assembly=WalletWasabi.Gui" />
<StyleInclude Source="resm:WalletWasabi.Gui.Styles.Styles.xaml?assembly=WalletWasabi.Gui" />
<StyleInclude Source="resm:WalletWasabi.Gui.Icons.Icons.xaml?assembly=WalletWasabi.Gui" />
<StyleInclude Source="resm:WalletWasabi.Gui.Controls.NoparaPasswordBox.xaml?assembly=WalletWasabi.Gui" />
<StyleInclude Source="resm:WalletWasabi.Gui.Controls.TogglePasswordBox.xaml?assembly=WalletWasabi.Gui" />
<StyleInclude Source="resm:WalletWasabi.Gui.Controls.MultiTextBox.xaml?assembly=WalletWasabi.Gui" />
<StyleInclude Source="resm:WalletWasabi.Gui.Controls.BusyIndicator.xaml?assembly=WalletWasabi.Gui" />
<StyleInclude Source="resm:WalletWasabi.Gui.Controls.EditableTextBlock.xaml?assembly=WalletWasabi.Gui" />
@@ -58,7 +58,7 @@ internal async Task RunAsync(string walletName, bool mixAll, bool keepMixAlive)
}
if (PasswordHelper.IsTrimable(password, out password))
{
Console.WriteLine(PasswordHelper.TrimmedMessage);
Console.WriteLine(PasswordHelper.TrimWarnMessage);
}
}
while (!PasswordHelper.TryPassword(keyManager, password, out compatibilityPassword));
@@ -1,7 +1,7 @@
<lockscreen:PinLockScreen xmlns="https://github.com/avaloniaui"
<lockscreen:PinLockScreen xmlns="https://github.com/avaloniaui"
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
xmlns:controls="clr-namespace:WalletWasabi.Gui.Controls;assembly=WalletWasabi.Gui"
xmlns:lockscreen="clr-namespace:WalletWasabi.Gui.Controls.LockScreen;assembly=WalletWasabi.Gui"
xmlns:lockscreen="clr-namespace:WalletWasabi.Gui.Controls.LockScreen;assembly=WalletWasabi.Gui"
x:Class="WalletWasabi.Gui.Controls.LockScreen.PinLockScreen"
IsLocked="{Binding IsLocked}">
<lockscreen:PinLockScreen.Styles>
@@ -34,7 +34,7 @@
<Grid Classes="Shade" Background="{DynamicResource ThemeBackgroundBrush}">
<controls:GroupBox VerticalAlignment="Center" HorizontalAlignment="Center" TextBlock.FontSize="25" Padding="20" Margin="10">
<DockPanel LastChildFill="True">
<controls:NoparaPasswordBox x:Name="InputField" Password="{Binding PinInput}" Width="300" DockPanel.Dock="Top" Margin="4 0 4 20" Watermark="PIN" UseFloatingWatermark="True" />
<controls:TogglePasswordBox x:Name="InputField" Text="{Binding PinInput}" Width="300" DockPanel.Dock="Top" Margin="4 0 4 20" Watermark="PIN" />
<Grid DockPanel.Dock="Bottom">
<TextBlock Text="Wrong PIN!" Margin="0,12,0,0" VerticalAlignment="Center" FontSize="20" Classes="warningMessage" IsVisible="{Binding WarningMessageVisible}" />
</Grid>
@@ -28,7 +28,7 @@ public PinLockScreen() : base()
{
InitializeComponent();

var inputField = this.FindControl<NoparaPasswordBox>("InputField");
var inputField = this.FindControl<TogglePasswordBox>("InputField");

this.WhenAnyValue(x => x.IsLocked)
.Where(x => x)
@@ -53,7 +53,7 @@ protected override void OnAttachedToVisualTree(VisualTreeAttachmentEventArgs e)
.ObserveOn(RxApp.MainThreadScheduler)
.Subscribe(_ =>
{
var inputField = this.FindControl<NoparaPasswordBox>("InputField");
var inputField = this.FindControl<TogglePasswordBox>("InputField");
inputField.Focus();
});
}
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.