Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FirstSeen of SmartTransaction (MempoolStore Breakdown Part 2) #2198

Merged
merged 2 commits into from Sep 2, 2019

Conversation

@nopara73
Copy link
Collaborator

commented Sep 1, 2019

I decided to break down PR #2188 to reviewable parts. In this PR I fix the FirstSeen property of the SmartTransaction. @lontivero please review this.

Previously there was a FirstSeenIfMempoolTime nullable property, which got set when the transaction arrived and if the transaction confirmed it got set to null. I removed the nullability and renamed it to FirstSeen.

@nopara73 nopara73 requested a review from lontivero Sep 1, 2019

@nopara73 nopara73 changed the title Fix FirstSeen of SmartTransaction Fix FirstSeen of SmartTransaction (MempoolStore Breakdown Part 2) Sep 1, 2019

@lontivero
Copy link
Collaborator

left a comment

LGTM.

Update WalletWasabi/Models/SmartTransaction.cs
Co-Authored-By: Lucas Ontivero <lontivero@users.noreply.github.com>

@nopara73 nopara73 merged commit 3ebfcd7 into zkSNACKs:master Sep 2, 2019

3 of 4 checks passed

Wasabi.Linux #20190902.2 failed
Details
CodeFactor No issues found.
Details
Wasabi.Osx #20190902.2 succeeded
Details
Wasabi.Windows #20190902.2 succeeded
Details

@nopara73 nopara73 deleted the nopara73:dt branch Sep 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.