Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapped warning messages #2200

Closed
wants to merge 4 commits into from

Conversation

@jmacato
Copy link
Collaborator

commented Sep 1, 2019

Experimental PR request for what i have in mind since last week (inspired by PR #2187 & Avalonia's DataTemplate magic).

This PR centralizes all warn/info/error/validation messages from the ViewModels and takes care of having the message expire and can be easily themed with the right DataTemplate styling.

Not for merging until concept is acknowledged.

cc @danwalmsley

jmacato added 2 commits Sep 1, 2019
for ViewModels.
<StackPanel Orientation="Horizontal">
<DrawingPresenter Margin="2" VerticalAlignment="Center">
<DrawingGroup>
<GeometryDrawing Brush="#FFF6F6F6" Geometry="F1M7.5,2L2,12 4,14 13,14 15,12 9.5,2z" />

This comment has been minimized.

Copy link
@jmacato

jmacato Sep 1, 2019

Author Collaborator

These ugly Geometry icons will be moved to Icons.xaml when we can pick the right ones.

jmacato added 2 commits Sep 1, 2019
…nch...
@jmacato jmacato force-pushed the jmacato:wrapped-warning-messages branch from 6352179 to 858dfa9 Sep 1, 2019
@@ -33,5 +35,52 @@
<DataTemplate DataType="id:IView">
<cont:ViewModelViewHost DataContext="{Binding Context}" />
</DataTemplate>

<DataTemplate DataType="sys:Exception">

This comment has been minimized.

Copy link
@jmacato

jmacato Sep 1, 2019

Author Collaborator

@danwalmsley Do you know of any way that we can move these DataTemplates to Styles.xaml?

Copy link
Collaborator

left a comment

We're replacing most of our warning messages with Avalonia notifications. So it's best if we put this PR on hold. @danwalmsley @jmacato do you agree? #1359

@jmacato

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 1, 2019

@nopara73 I agree, this is just for what i had in mind and basically just a proof of concept :)

@danwalmsley

This comment has been minimized.

Copy link
Collaborator

commented Sep 1, 2019

@jmacato @nopara73 this is like a common way to style exceptions that appear in the UI, I think they should probably be presented inside the notifications, but this PR is relevant once we have the notifications working.

@molnard

This comment has been minimized.

Copy link
Collaborator

commented Sep 4, 2019

I created an issues for this, please add the "Fixes" keyword to this PR if the issue is good
#2208

@jmacato jmacato added the UX label Sep 4, 2019
@benthecarman

This comment has been minimized.

Copy link
Collaborator

commented Sep 4, 2019

Closes #1711 as well

@molnard

This comment has been minimized.

Copy link
Collaborator

commented Sep 26, 2019

LGTM but it will be replaced by notifications and for this reason, this would probably never merged in the future.

@jmacato

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 26, 2019

@molnard I think the main idea of this concept PR was already implemented in #2223 so i think this can be closed :)

@jmacato jmacato closed this Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.