Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validations system refactor. #2223

Merged
merged 24 commits into from Sep 10, 2019

Conversation

@jmacato
Copy link
Collaborator

commented Sep 9, 2019

fixes #2208; Enables a more expressive error messaging for validation methods. Will also help with future work with #2200 .
cc : @molnard

jmacato added 3 commits Sep 9, 2019
@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Sep 9, 2019

Great concept!

@jmacato

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 9, 2019

This PR is blocked by AvaloniaUI/Avalonia#2867 . Will need a hotfix release on Avalonia with that PR. Though i have a workaround (would be a bit ugly). Workaround worked, somehow :)

jmacato added 4 commits Sep 9, 2019
Serialize then Deserialize via Converter the ErrorDescriptor as a wor…
…karound. Remove this hack when we update to Avalonia 0.9.
jmacato and others added 4 commits Sep 10, 2019
molnard added 3 commits Sep 10, 2019

@molnard molnard added this to In Progress in v1.1.7 via automation Sep 10, 2019

jmacato added 3 commits Sep 10, 2019
Add a converter that colors the border according to
aggregated error severities.
@jmacato

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 10, 2019

image
Multiple Errors and the Border color is determined by the highest severity error.

jmacato and others added 5 commits Sep 10, 2019
@nopara73

This comment has been minimized.

Copy link
Collaborator

commented Sep 10, 2019

@jmacato The keyword is fixes/resolves, etc.., not "addresses".

@nopara73 nopara73 merged commit ec76f23 into zkSNACKs:master Sep 10, 2019

3 of 4 checks passed

Wasabi.Linux #20190910.15 failed
Details
CodeFactor No issues found.
Details
Wasabi.Osx #20190910.15 succeeded
Details
Wasabi.Windows #20190910.15 succeeded
Details

v1.1.7 automation moved this from In Progress to Done Sep 10, 2019

@jmacato jmacato deleted the jmacato:error-template-revamp branch Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5 participants
You can’t perform that action at this time.