Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start Bitcoin Core with Wasabi #2495

Merged
merged 66 commits into from Nov 12, 2019
Merged

Start Bitcoin Core with Wasabi #2495

merged 66 commits into from Nov 12, 2019

Conversation

@nopara73
Copy link
Collaborator

nopara73 commented Nov 4, 2019

No description provided.

nopara73 added 28 commits Oct 30, 2019
…t launch Core in the first place.
@nopara73

This comment has been minimized.

Copy link
Collaborator Author

nopara73 commented Nov 11, 2019

@MaxHillebrand That's ok. You did not have the block just yet.

nopara73 added 3 commits Nov 11, 2019
WalletWasabi/Bases/PeriodicRunner.cs Outdated Show resolved Hide resolved
@molnard

This comment has been minimized.

Copy link
Collaborator

molnard commented Nov 11, 2019

Every minute I get this error:

2019-11-11 18:37:08 ERROR       PeriodicRunner (53)     NBitcoin.RPC.NoEstimationException: The FeeRate couldn't be estimated because of insufficient data from Bitcoin Core. Try to use smaller nBlock, or wait Bitcoin Core to gather more data.
   at NBitcoin.RPC.RPCClient.EstimateSmartFeeAsync(Int32 confirmationTarget, EstimateSmartFeeMode estimateMode)
   at NBitcoin.RPC.RPCClientExtensions.EstimateSmartFeeAsync(RPCClient rpc, Int32 confirmationTarget, EstimateSmartFeeMode estimateMode, Boolean simulateIfRegTest, Boolean tryOtherFeeRates) in C:\work\WalletWasabi\WalletWasabi\Extensions\RPCClientExtensions.cs:line 52
   at NBitcoin.RPC.RPCClientExtensions.EstimateHalfFeesAsync(RPCClient rpc, IDictionary`2 estimations, Int32 smallTarget, Int32 smallFee, Int32 largeTarget, Int32 largeFee, EstimateSmartFeeMode estimateMode, Boolean simulateIfRegTest, Boolean tolerateBitcoinCoreBrainfuck) in C:\work\WalletWasabi\WalletWasabi\Extensions\RPCClientExtensions.cs:line 182
   at NBitcoin.RPC.RPCClientExtensions.EstimateAllFeeAsync(RPCClient rpc, EstimateSmartFeeMode estimateMode, Boolean simulateIfRegTest, Boolean tolerateBitcoinCoreBrainfuck) in C:\work\WalletWasabi\WalletWasabi\Extensions\RPCClientExtensions.cs:line 140
   at WalletWasabi.BitcoinCore.Monitoring.RpcFeeProvider.ActionAsync(CancellationToken cancel) in C:\work\WalletWasabi\WalletWasabi\BitcoinCore\Monitoring\RpcFeeProvider.cs:line 35
   at WalletWasabi.Bases.PeriodicRunner`1.ForeverMethodAsync() in C:\work\WalletWasabi\WalletWasabi\Bases\PeriodicRunner.cs:line 45
nopara73 added 2 commits Nov 11, 2019
@nopara73

This comment has been minimized.

Copy link
Collaborator Author

nopara73 commented Nov 11, 2019

@molnard Fixed the logs.

nopara73 added 4 commits Nov 11, 2019
@molnard

This comment has been minimized.

Copy link
Collaborator

molnard commented Nov 12, 2019

I got this immediately after the start. However, Wasabi keeps going after maybe intended but still an NRE. Other == null
image

image

nopara73 added 2 commits Nov 12, 2019
@nopara73

This comment has been minimized.

Copy link
Collaborator Author

nopara73 commented Nov 12, 2019

As we discussed with Lucas, merging.

@nopara73 nopara73 merged commit f5b0839 into zkSNACKs:master Nov 12, 2019
4 checks passed
4 checks passed
CodeFactor 2 issues fixed.
Details
Wasabi.Linux #20191112.3 succeeded
Details
Wasabi.Osx #20191112.3 succeeded
Details
Wasabi.Windows #20191112.3 succeeded
Details
@nopara73 nopara73 deleted the nopara73:corestart branch Nov 12, 2019
@yahiheb

This comment has been minimized.

Copy link
Collaborator

yahiheb commented Nov 12, 2019

Shouldn't lock (WalletServicesLock) have curly braces?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.