Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local NullNotificationManager #2657

Merged
merged 2 commits into from Nov 30, 2019
Merged

Conversation

lontivero
Copy link
Collaborator

Closes #2649

MaxHillebrand
MaxHillebrand previously approved these changes Nov 28, 2019
Copy link
Member

@MaxHillebrand MaxHillebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Qubes 4 Debian 10

It seems to be fixed, I can start the daemon without seeing the error logs, but I'm still loading filters, so I cannot mix on testnet, so I'm not sure if it works properly after all...

Copy link
Contributor

@nopara73 nopara73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK, Implementation NACK

  • variable naming
  • one class one file
  • fully qualified class name

@nopara73
Copy link
Contributor

I will clean this up and fix because I'm not comfortable having this bug in the master.

@molnard
Copy link
Collaborator

molnard commented Nov 30, 2019

IMO, you can ask the Locator if it has an instance of a specified object or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daemon fails to start
4 participants