Wallet explorer utility buttons. #3384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lity-buttons # Conflicts: # WalletWasabi.Gui/Controls/WalletExplorer/WalletExplorerView.xaml # WalletWasabi.Gui/Controls/WalletExplorer/WalletExplorerViewModel.cs # WalletWasabi.Gui/Controls/WalletExplorer/WalletViewModel.cs
Co-Authored-By: Lucas Ontivero <lontivero@users.noreply.github.com>
…danwalmsley/WalletWasabi into wallet-explorer-utility-buttons
…el.cs Co-Authored-By: yahiheb <52379387+yahiheb@users.noreply.github.com>
Co-Authored-By: yahiheb <52379387+yahiheb@users.noreply.github.com>
…danwalmsley/WalletWasabi into pr/3373-wallet-explorer-utility-buttons
|
IMO this PR can be merged. Most of it is done by @danwalmsley and @jmacato here: #3373, but since I created a new PR, I cannot add an approve to this, but take this comment as an ACK. |
danwalmsley
previously approved these changes
Mar 28, 2020
There was a problem hiding this comment.
Was a couple of issues with the selection logic, pushed a fix.
Also iv made Wallet protected as important not to be public, we really want to avoid in future developer accessing a Wallet that doesnt belong to the associated viewmodel.
WalletViewModel property iv made private also for the same reason and added an ExpandWallet method.
added 2 commits
March 28, 2020 12:32
This reverts commit 252bea3. # Conflicts: # WalletWasabi.Gui/ViewModels/WasabiWalletDocumentTabViewModel.cs
|
molnard
requested changes
Mar 28, 2020
WalletWasabi.Gui/Controls/WalletExplorer/WalletExplorerViewModel.cs
Outdated
Show resolved
Hide resolved
molnard
approved these changes
Mar 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build on top of #3373, thus closes #3373.
It fixes what @yahiheb noted: #3373 (comment)