Do not access Global via service locator in MainWindowViewModel c…

[kiminuo]

…lass

[molnard]

Very well done. Much cleaner!

[nopara73]

We're going back and forth with this. I remember like 3 times this was flipped and flopped: we started out with statics, then @NicolasDorier added them to constructors instead, then @danwalmsley, @molnard and me removed these from the constructor. I don't mind any of the two approaches, it's just let's settle with a single one. I suggest @danwalmsley to have the final say.

[NicolasDorier]

I removed every static in the hope of making unit tests where you could simulate several wasabi wallets at once via their view model.

Those unit test PR never got merged. If there is a single static singleton, then interactions between several wasabi wallet can't be tested, thus defeating the whole purpose of the exercise.

@danwalmsley reason to reintroduce singleton was meant to be temporary if I remember.

[lontivero]

This is better than what we have.

[danwalmsley]

We're going back and forth with this. I remember like 3 times this was flipped and flopped: we started out with statics, then @NicolasDorier added them to constructors instead, then @danwalmsley, @molnard and me removed these from the constructor. I don't mind any of the two approaches, it's just let's settle with a single one. I suggest @danwalmsley to have the final say.

Offline in meetings and discussions with @kiminuo @lontivero @molnard the direction we would like to go in is:

1. interfaces passed to the viewmodels representing only the dependencies required by that viewmodel.
2. no statics / globals

[molnard]

We're going back and forth with this. I remember like 3 times this was flipped and flopped: we started out with statics, then @NicolasDorier added them to constructors instead, then @danwalmsley, @molnard and me removed these from the constructor. I don't mind any of the two approaches, it's just let's settle with a single one. I suggest @danwalmsley to have the final say.

Offline in meetings and discussions with @kiminuo @lontivero @molnard the direction we would like to go in is:

1. interfaces passed to the viewmodels representing only the dependencies required by that viewmodel.

Interfaces or objects but yes.

2. no statics / globals

Agree, statics can be allowed in some cases but only if make sense to use them.