Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the nuget problem on CI windows #3852

Merged
merged 15 commits into from Jul 3, 2020
Merged

Conversation

molnard
Copy link
Collaborator

@molnard molnard commented Jul 2, 2020

Constant Red X on windows CI makes devs ignore it and starting to become negligible.

Versions of nuget.exe since 3.4.1 have not auto-included nuget.org as a source. It needs to be included in your nuget.config file (recommended) or added by the DotNetCoreCLI/NuGetCommand task. When you have includeNuGetOrg set to 'true', you should see 'Adding the following sources to the config file: NuGetOrg' in a debug build's log

Source

I made 2 things:

  1. Solve the NuGet offline package problems by disabling the cache for packages.
  2. Disabled the constantly failing test on windows CI NodeBuildingTests.GetVersionTestsAsync by filtering it out. - will be solved in another PR

image

@molnard molnard marked this pull request as draft July 2, 2020 14:20
@molnard
Copy link
Collaborator Author

molnard commented Jul 3, 2020

Useful documentation on this https://github.com/Microsoft/vstest-docs/blob/master/docs/filter.md

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Jul 3, 2020
@molnard molnard marked this pull request as ready for review July 3, 2020 09:49
Copy link
Contributor

@nopara73 nopara73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a hack.

@kiminuo
Copy link
Collaborator

kiminuo commented Jul 3, 2020

@molnard NodeBuildingTests.GetVersionTestsAsync - this test may fail for a valid reason. I have actually had a look at it a few days ago and there is:

  1. using var process = Start(arguments, openConsole);
    - starting the process
  2. process.EnableRaisingEvents = true;
    - setting EnableRaisingEvents and registering of Exited
    Note that this is after the process is already running so you are not guaranteed that Exited is called (even though it's unlikely) but I don't like it personally.

@pull-request-size pull-request-size bot added size/XS and removed size/S labels Jul 3, 2020
@molnard
Copy link
Collaborator Author

molnard commented Jul 3, 2020

@nopara73 approved IRL

@molnard molnard merged commit a42f351 into zkSNACKs:master Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants