Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix horizontal scroll bar issues #4272

Merged
merged 1 commit into from Sep 2, 2020

Conversation

yahiheb
Copy link
Collaborator

@yahiheb yahiheb commented Aug 31, 2020

@danwalmsley
Copy link
Collaborator

I think we should be setting a max width for these pages and standardise it across wasabi rather than allow the text boxes to just grow and grow.

Copy link
Member

@MaxHillebrand MaxHillebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK
screenshot_20200901_091057

Though I agree with @danwalmsley comments for a proper solution.

@nopara73
Copy link
Contributor

nopara73 commented Sep 1, 2020

See real diff like this: https://github.com/zkSNACKs/WalletWasabi/pull/4272/files?w=1

@danwalmsley can you take a look at it. It should be immediately obvious for you if that's good or not and you can merge.

For me it looks good.

Copy link
Collaborator

@danwalmsley danwalmsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Note we will re-do these layouts correctly when we move to fluent controls.

@danwalmsley danwalmsley merged commit 737959f into zkSNACKs:master Sep 2, 2020
@yahiheb yahiheb deleted the horizontal-scrollbar branch September 2, 2020 13:20
@nopara73 nopara73 added this to Backlog in Next (Backport) Release Oct 1, 2020
@molnard molnard moved this from Backlog to Cherry picked in Next (Backport) Release Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Coin Details tab needs horizontal scrollbar
4 participants