New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo fix-'To Bitcoin address' instead of 'Via' #6731
Conversation
This is how it reads currently, so I think it is not a typo:
|
Yes, but the preview is meant to be read as a summary all together. |
Hhm yes, I guess it's more an interpretation/personal preference.
I understand what you mean and reading it that way it does make sense. Imo, Via can be confusing. Using To it's more clear that it's the final destination, while via is usually being used by way of or through. Overall, I think using To is more clear. |
Agree |
@@ -49,7 +49,7 @@ | |||
|
|||
<Separator /> | |||
<c:PreviewItem Icon="{StaticResource transceive_regular}" | |||
Text="via Bitcoin address"> | |||
Text="To Bitcoin address"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Text="To Bitcoin address"> | |
Text="to Bitcoin address"> |
should be lower case to flow in the whole sentence.
to
is better than via
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, it should not!
All other lines start capitalized too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The initial plan was as @yahiheb described. But since then the things have changed... New rows added... Order changed.
I would say should be lower case if there is no separator between the two sections, otherwise capitalized.
Small typo fix at
Send - Preview Transaction
screen: To Bitcoin address instead of current via Bitcoin address