Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fix-'To Bitcoin address' instead of 'Via' #6731

Merged
merged 1 commit into from Nov 26, 2021
Merged

Typo fix-'To Bitcoin address' instead of 'Via' #6731

merged 1 commit into from Nov 26, 2021

Conversation

MarnixCroes
Copy link
Collaborator

Small typo fix at Send - Preview Transaction screen: To Bitcoin address instead of current via Bitcoin address

@yahiheb
Copy link
Collaborator

yahiheb commented Nov 22, 2021

This is how it reads currently, so I think it is not a typo:

A total of {amount} will be sent to and / or known by {label} via Bitcoin address {address}

@MarnixCroes
Copy link
Collaborator Author

This is how it looks like
image

@yahiheb
Copy link
Collaborator

yahiheb commented Nov 22, 2021

Yes, but the preview is meant to be read as a summary all together.

@MarnixCroes
Copy link
Collaborator Author

Hhm yes, I guess it's more an interpretation/personal preference.

A total of {amount} will be sent to and / or known by {label} via Bitcoin address {address}

I understand what you mean and reading it that way it does make sense.

Imo, Via can be confusing. Using To it's more clear that it's the final destination, while via is usually being used by way of or through.
Like: I'm going to Paris, via Londen. Via is being used more as a 'hop', not final destination.

Overall, I think using To is more clear.

@ghost
Copy link

ghost commented Nov 22, 2021

Imo, Via can be confusing. Using To it's more clear that it's the final destination, while via is usually being used by way of or through.
Like: I'm going to Paris, via Londen. Via is being used more as a 'hop', not final destination.
Overall, I think using To is more clear.

Agree

@lontivero lontivero requested a review from soosr November 23, 2021 09:55
@@ -49,7 +49,7 @@

<Separator />
<c:PreviewItem Icon="{StaticResource transceive_regular}"
Text="via Bitcoin address">
Text="To Bitcoin address">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Text="To Bitcoin address">
Text="to Bitcoin address">

should be lower case to flow in the whole sentence.

to is better than via.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, it should not!

All other lines start capitalized too.

Copy link
Collaborator

@soosr soosr Nov 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial plan was as @yahiheb described. But since then the things have changed... New rows added... Order changed.
I would say should be lower case if there is no separator between the two sections, otherwise capitalized.

@danwalmsley danwalmsley merged commit 50edada into zkSNACKs:master Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants