Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Revert "Revert "[osx] update avalonia to fix cmd key gestures."" #821

Merged
merged 1 commit into from Nov 9, 2018

Conversation

Projects
None yet
3 participants
@nopara73
Copy link
Collaborator

commented Nov 7, 2018

Maybe it's still good. Wrong branch was tested by @molnard

@nopara73 nopara73 referenced this pull request Nov 7, 2018

Closed

Unable to paste #816

@molnard

This comment has been minimized.

Copy link
Contributor

commented Nov 7, 2018

@danwalmsley I had a git problem please check original pull request comment.
About the current PR: it looks like the first cmd-v after copied something to the clipboard is not working. If I press the cmd-v again it starts working. If I press cmd-v anywhere in WasabiWallet even not on a textbox then is starts working. So the first cmd-v after copy is swallowed somewhere in wasabi.
If I copy something to the clipboard and paste it to notepad then go back to wallet and cmd-v on textbox it is working immediately.

@danwalmsley

This comment has been minimized.

Copy link
Contributor

commented Nov 7, 2018

@nopara73 @molnard after some investigation iv found that this issue isn't related to key input handling, so you should put the fix back into master.

The issue is somewhere in Avalonias clipboard handling, which I will have to fix with a separate PR since its a different issue.

@nopara73

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 8, 2018

@danwalmsley I'm afraid merging something buggy would just generate more support requests.

@nopara73 nopara73 changed the title Revert "Revert "[osx] update avalonia to fix cmd key gestures."" [WIP] Revert "Revert "[osx] update avalonia to fix cmd key gestures."" Nov 8, 2018

@nopara73 nopara73 merged commit 2598ccb into master Nov 9, 2018

1 of 4 checks passed

continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
CodeFactor No issues found.
Details

@nopara73 nopara73 deleted the revert-820-revert-818-fixes/osx_cmd_key_gestures branch Nov 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.