Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement better mix coin selection #881

Merged
merged 1 commit into from Nov 23, 2018

Conversation

Projects
None yet
3 participants
@nopara73
Copy link
Collaborator

commented Nov 23, 2018

@lontivero @molnard I refactored how we select coins for mixing. Can one of you review it?

@nopara73 nopara73 requested review from lontivero and molnard Nov 23, 2018

@lontivero

This comment has been minimized.

Copy link
Contributor

commented Nov 23, 2018

Sure

@nopara73 nopara73 merged commit fa7e72a into master Nov 23, 2018

2 of 4 checks passed

continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
CodeFactor No issues found.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@nopara73 nopara73 deleted the mix-coin-selection branch Nov 23, 2018

@lontivero
Copy link
Contributor

left a comment

It looks okay to me. I think that given these two methods are public and have no many dependencies, it would be good to have UTs to confirm their correctness, even when there are no evident flaws on them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.