Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to acknowledge contributors? #8

Closed
MaxHillebrand opened this issue Jul 19, 2019 · 71 comments

Comments

@MaxHillebrand
Copy link
Collaborator

commented Jul 19, 2019

This is an open source archive of knowledge, and the goal is to have both users and developers collaborate to ensure that Wasabi is properly explained. We already have many contributions [for example the FAQ], and we will continue to see new peers joining the effort.

The question is

How do we properly attribute and thank the creators of the specific information?

Git helps here a lot, it's clear who has done what commit. However, for example the FAQ was written by several others, yet I committed it to this new repository, thus obfuscating who actually created it.

I don't think it is a good idea to have attribution directly in the doc, meaning that every line has a footnote with whom has written it. This will clutter the doc and GitBook.

How about we have a separate file that lists all the contributors, we could maybe link to the specific contributions they've made, but that will be a pain to keep up to date...

Ultimately, I'm not sure, so this issue is open to start the conversation :)

@raindogdance

This comment has been minimized.

Copy link

commented Jul 21, 2019

I am neither very experienced with Git/GitBook/GitHub nor with open source contribution in general, so take my opinion with a grain of salt :)

I think it would be nice to have a line somewhere mentioning all contributors, but it's not necessary to mention the specific commits etc. Perhaps something like: "This documentation was created with the help of the following contributors: [...]" is sufficient.

Alternatively, an extra page in the doc with the mentions of the contributors nicks and links to either their Twitter or GitHub repo or some project of theirs.

@dennisreimann

This comment has been minimized.

Copy link
Collaborator

commented Aug 1, 2019

All Contributors might be an option here :)

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 1, 2019

I guess this will be an entire re-imagination of the dojo...

All-Contributors looks good.

@dennisreimann

This comment has been minimized.

Copy link
Collaborator

commented Aug 2, 2019

I tried it with a personal project and IMHO this is a great fit. Especially since it is very easy to mark contributors in issues and pull requests and also note what they contributed. 👍

The initial setup is easy and after that you can start tagging people as contributors right away. The bot then opens a PR that adds the person to the list in the README. 👌

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 3, 2019

I like this!
But I don't think it's good to add all the dependencies [chat bot and such] to the main repo, but there should not be many security concerns to have it in the docs repo?
But then we could not use the chat bot on issues of the main repo, and if we'd like to add a contributor, we'd have to open a new issue / pr in the docs repo? I don't think this would be too bad, but would take away some of the UX of the bot.

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 6, 2019

I have opened a new thread on the SourceCred forum to see how we might use their tool to find out the quantity and quality of contributions!

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 7, 2019

@all-contributors please add @dennisreimann for design

@allcontributors

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

@MaxHillebrand

I've put up a pull request to add @dennisreimann! 🎉

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 7, 2019

This setup was ridiculously easy...
Let's make sure that everything is added properly.

I think this should also be added to the dojo!

@zkSNACKs zkSNACKs deleted a comment from allcontributors bot Aug 7, 2019

@dennisreimann

This comment has been minimized.

Copy link
Collaborator

commented Aug 7, 2019

@all-contributors please add @MaxHillebrand for content, doc, example, maintenance, projectManagement, review and video.

@allcontributors

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

@dennisreimann

I've put up a pull request to add @MaxHillebrand! 🎉

@dennisreimann

This comment has been minimized.

Copy link
Collaborator

commented Aug 7, 2019

@all-contributors please add @thunderBiscuit for ideas.

@allcontributors

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

@dennisreimann

I've put up a pull request to add @thunderBiscuit! 🎉

@dennisreimann

This comment has been minimized.

Copy link
Collaborator

commented Aug 7, 2019

@all-contributors please add @mayankchhabra for design.

@allcontributors

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

@dennisreimann

I've put up a pull request to add @mayankchhabra! 🎉

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 7, 2019

@all-contributors please add @6102bitcoin for idea and content

@allcontributors

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

@MaxHillebrand

I've put up a pull request to add @6102bitcoin! 🎉

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 8, 2019

@all-contributors please add @nopara73 for code idea maintenance review and talk

@allcontributors

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

@MaxHillebrand

I've put up a pull request to add @nopara73! 🎉

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 8, 2019

@all-contributors please add @molnard for blog code review and maintenance

@allcontributors

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

@MaxHillebrand

I've put up a pull request to add @xavierfiechter! 🎉

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 8, 2019

@all-contributors please add @gugero for code and bugs

@allcontributors

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

@MaxHillebrand

Could not find the user gugero on github.

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 8, 2019

@all-contributors please add @guggero for code and bug

@allcontributors

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

@MaxHillebrand

I've put up a pull request to add @guggero! 🎉

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 8, 2019

@all-contributors please add @AdamISZ for idea example and review

@allcontributors

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

@MaxHillebrand

I've put up a pull request to add @AdamISZ! 🎉

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 8, 2019

@all-contributors please add @chris-belcher for idea example and review

@allcontributors

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

@MaxHillebrand

I've put up a pull request to add @chris-belcher! 🎉

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 8, 2019

Sorry for spamming you all with this huge tread...

But now that I have you all together, I want to sincerely THANK YOU ALL for your invaluable contributions to this libre & open source projects. You all are heroes of Bitcoin privacy, and I hold your support in very high regard!

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 8, 2019

@all-contributors please add @RiccardoMasutti for docs and content

@allcontributors

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 8, 2019

@all-contributors please add @CryptoRafe for docs and content

@allcontributors

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

@MaxHillebrand

I've put up a pull request to add @CryptoRafe! 🎉

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 8, 2019

@all-contributors please add @kravens for docs and content

@allcontributors

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

@MaxHillebrand

I've put up a pull request to add @kravens! 🎉

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 8, 2019

@all-contributors please add @michaeltoth for docs and content

@allcontributors

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

@MaxHillebrand

I've put up a pull request to add @michaeltoth! 🎉

@MaxHillebrand MaxHillebrand referenced this issue Aug 8, 2019
0 of 4 tasks complete
@chris-belcher

This comment has been minimized.

Copy link

commented Aug 8, 2019

Please don't use my name to promote Wasabi wallet. Remove it from this list. Thanks.

@lontivero

This comment has been minimized.

Copy link
Collaborator

commented Aug 8, 2019

@MaxHillebrand what is the criteria for adding people to this list? I ask this because if well it is true that we all learn and get technical feedback from others, I didn't find any github issue, pull request, commit, content or any other material from @chris-belcher related to Wasabi so, yes, it looks like we are using his name to promote Wasabi.

@chris-belcher our apologies, this was not our intention, we are going to revert this asap.

@MaxHillebrand

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 9, 2019

Sorry @chris-belcher, it's not my intention to mis-represent you, the commit is already reverted here.

@lontivero, All-Contributors is designed to acknowledge literally ALL the peers who have supported Wasabi, not just those who code [they are already here]. You can find a list of all the default categories of support ħere, as you see, it includes those with high level ideas [like Belcher], asking good questions, or managing the finances of a project.

So at first, we will go by these labels to thank all the supporters. But we are also thinking of how to integrate with the belt logic of the Wasabi dojo. So this is a work in progress and open for review and improvements.

But since so many peers are tagged in this thread - it might be better to move this conversation to another issue or to Slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.