From 8ab175895f94d6c542e58506c5bd838c8069a342 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kat=20March=C3=A1n?= Date: Wed, 12 Apr 2017 15:03:45 -0700 Subject: [PATCH] fix(finalize): don't try to cache manifests we can't get a good key for --- lib/finalize-manifest.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/finalize-manifest.js b/lib/finalize-manifest.js index b598e92..37f0882 100644 --- a/lib/finalize-manifest.js +++ b/lib/finalize-manifest.js @@ -49,7 +49,8 @@ function finalizeManifest (pkg, spec, opts) { ? new Manifest(pkg, props) : new Manifest(props) }).then(manifest => { - if (!opts.cache) { + const cacheKey = key || finalKey(manifest, spec) + if (!opts.cache || !cacheKey) { return manifest } else { opts.metadata = { @@ -58,7 +59,7 @@ function finalizeManifest (pkg, spec, opts) { type: 'finalized-manifest' } return cache.put( - opts.cache, key || finalKey(manifest, spec), '.', opts + opts.cache, cacheKey, '.', opts ).then(() => manifest) } })