This repository has been archived by the owner on Jul 3, 2019. It is now read-only.
feat(scopes): new scopeTargets option #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a relatively small step as far as having a good story around auth, but I think at least making it a bit clearer what these options are and where they come from is going to be nice. At least opt-check doesn't have a ton of random @-opts now.
strugee
pushed a commit
to strugee/pacote
that referenced
this pull request
Mar 9, 2021
Occasionally, a package installed from a hosted git repo requires its .gitignore in order to properly run its install/prepare process. Since we should treat git dependencies as being just like installing from an install cut from the actual git repo itself, it's inappropriate to munge the .gitignore into .npmignore at this step (even though it _is_ appropriate to do so in most other cases with remote tarballs). This adds the `allowGitIgnore` flag, which is then in turn used by the GitFetcher when it makes its call to RemoteFetcher to download and extract the hosted tarball for preparation. This was not an issue in npm v6, because prior to npm v7, hosted git snapshot tarballs were not used, so it never would go through the code path of using a 'remote' type fetcher to download the contents of a git repository (which was also much slower). Fixes: npm/cli#2144 PR-URL: npm/pacote#59 Credit: @isaacs Close: zkat#59 Reviewed-by: @nlf
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a relatively small step as far as having a good
story around auth, but I think at least making it a bit
clearer what these options are and where they come from
is going to be nice.
At least opt-check doesn't have a ton of random @-opts now.