Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity magic numbers / Wrecking ball #243

merged 3 commits into from May 18, 2020


Copy link

  • Replaced many entity magic numbers with constants
  • Entity A8 is the wrecking ball in Eagle's Tower
    (does that thing have a canonical name?)
  • Bonus: 1 ghost variable documented
    (is dialog 212 used? ...N-N-No!... ...N-not there!)

Copy link

Sweet! Thanks for the extensive labeling of entity constants throughout the code: as you noticed, it really makes easier to understand what some pieces of code are used for.

Oh, and I couldn't remember the dialog line, but from this wiki, the ...N-N-No!... ...N-not there! dialog is when attempting to enter a Dungeon while the Ghost is following Link.

@kemenaran kemenaran merged commit 03be831 into zladx:master May 18, 2020
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants