Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make HRAM shiftable #302

Merged
merged 10 commits into from
Aug 28, 2020
Merged

make HRAM shiftable #302

merged 10 commits into from
Aug 28, 2020

Conversation

zelosos
Copy link
Collaborator

@zelosos zelosos commented Aug 27, 2020

  • all HRAM labels are now used
  • complete HRAM is labeled
  • HRAM should be shiftable
  • comments added

Copy link
Collaborator

@kemenaran kemenaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the formatting and shiftability work!

ds 5 ; FFD2

; used in many different cases
hMultiPurpose0::
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you renamed the generic purpose registers from hScratch0 to hMultiPurpose0.

Is is because the "scratch" wording wasn't clear to you?

I initially chose "scratch" because it seems widely used in embedded systems programming (like scratch registers or scratch memory), so I guess I would rather keep it, unless for a good reason.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I renamed Scratch to MultiPurpose for readability.
I googeled for scratch, but all I found was stuff for the kiddy language scatch. You know the one with the cat as mascot and with drag and drop programming.
So I thought MultiPurpose is more specific and clear.
I made it a separate commit, so its easy to revert, if you want so.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, maybe if you googled and were still confused it means the name is not good enough. MultiPurpose seems good to me.

@kemenaran kemenaran merged commit c02fb19 into zladx:master Aug 28, 2020
@zelosos zelosos deleted the formatHRAM branch August 28, 2020 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants