src: declare all charmaps explicitely #449
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR explicitly declare all charmaps used throughout the code - without defaulting on ASCII as it previously did. This fixes
-Wunmapped-char
warnings on the (yet unreleased) rgbds 0.6. Credits to @ShadowOne333Implementation
AsciiCharmap
and aJpCharmap
.AsciiCharmap
has variations per revision.CreditsCharmap
is derived from theAsciiCharmap
, with additional patches per-language.This is slighly different from the implementation proposed by @ShadowOne333, but should work the same.