Skip to content

Add speakers to dialog lines #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 14, 2023
Merged

Conversation

KelseyHigham
Copy link
Collaborator

I added some of these by guessing; some of them by looking at the game; and some of them by changing data and seeing what changed. I tried to indicate when I didn't know something, so I don't think there are any errors.

  • I labeled "Narrator" lines to distinguish them from unlabeled lines.
  • I labeled "idk" lines to distinguish them from unlabeled lines.
  • I labeled player responses to questions as "Link".
  • I used official names from the Switch version where I knew them.
  • I only labeled English lines. I'm not sure whether the translations should use English character names, or localized ones.

This is kind of messy, but useful to translators, I think.

Co-authored-by: Tobias V. Langhoff <tobias@langhoff.no>
@KelseyHigham
Copy link
Collaborator Author

I think I addressed all changes and marked all conversations as resolved, but GitHub is still telling me this:

Merging is blocked
Merging can be performed automatically once the requested changes are addressed.

I think this can be merged now.

@kemenaran
Copy link
Collaborator

@tobiasvl I think you need to approve the PR to allow it to be merged

@tobiasvl
Copy link
Collaborator

Ah, right, sorry. I guess I didn't notice it because my review wasn't manually re-requested. LGTM!

@KelseyHigham KelseyHigham merged commit a549429 into zladx:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants