zip: conform slashes #637
Closed
zip: conform slashes #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmoinvaz
reviewed
Jul 16, 2022
mz_zip.c
Outdated
| @@ -787,12 +788,16 @@ static int32_t mz_zip_entry_write_header(void *stream, uint8_t local, mz_zip_fil | |||
| } | |||
|
|
|||
| if (err == MZ_OK) { | |||
| if (mz_stream_write(stream, filename, filename_length) != filename_length) | |||
| char conformed_filename[512]; | |||
There was a problem hiding this comment.
It would be better to just use MZ_ALLOC here, and if it returns NULL then return MZ_ERROR_MEM.
There was a problem hiding this comment.
Thanks @nmoinvaz, modifications checked in.
nmoinvaz
added
zip
|
I have decided to go a different route in #644 so we don't have to allocate any memory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conform slashes to MZ_PATH_SLASH_UNIX before writing to zip stream. See #636