New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open up develop branch for non-stable commits. #991
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #991 +/- ##
========================================
Coverage 76.30% 76.30%
========================================
Files 74 74
Lines 8305 8305
Branches 1363 1370 +7
========================================
Hits 6337 6337
Misses 1439 1439
Partials 529 529
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
c879335
to
fd1c81c
Compare
Replace ZLIBNG_VERNUM with a larger one with space for more accurate information. Replace ZLIBNG_VER_SUBREVISION with ZLIBNG_VER_MODIFIED and ZLIBNG_VER_STATUS.
Changed example.c to always print out the zlib-ng version, as it would likely not make sense to build it against stock zlib. Fixes the issue with the new ZLIBNG_VERNUM differing in length compared to the zlib one. |
@Dead2 I was kinda waiting for you to notice that issue... I didn't have any rush as I wanted to wait for CI to finish to see if there is any new warnings... |
LGTM. I like that you have kept the version number define and went with OpenSSL format. minizip-ng also uses openSSL format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Start 2.1.0 develop cycle.
Replace ZLIBNG_VERNUM with a larger one with space for more accurate information.
Replace ZLIBNG_VER_SUBREVISION with ZLIBNG_VER_MODIFIED and ZLIBNG_VER_STATUS.