Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comprehensive function name lookup #1010

Merged
merged 3 commits into from Nov 21, 2021
Merged

Comprehensive function name lookup #1010

merged 3 commits into from Nov 21, 2021

Conversation

ildar-shaimordanov
Copy link
Contributor

Supports any of:
-- function \s* name
-- function \s* /* multi-line comment */ \s* name
-- function \s* // single-line comment [\r\n]+ \s* name

Supports any of:
-- `function \s* name`
-- `function \s* /* multi-line comment */ \s* name`
-- `function \s* // single-line comment [\r\n]+ \s* name`
@zloirock
Copy link
Owner

Thanks, good catch.

@ildar-shaimordanov
Copy link
Contributor Author

Some checks seem not passed. Probably, some correction or jslint disabling is required.

@zloirock
Copy link
Owner

zloirock commented Nov 21, 2021

Yes. Please, follow ESLint recommendations (it's just the order of elements in groups).

@zloirock
Copy link
Owner

zloirock commented Nov 21, 2021

Also, it could be good to add some new asserts to /tests/tests/es.function.name.js.

@zloirock
Copy link
Owner

Thanks!

@zloirock zloirock merged commit cbb60c9 into zloirock:master Nov 21, 2021
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants