Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-js-builder): change blacklist term #882

Merged
merged 1 commit into from Nov 24, 2020

Conversation

@rivajunior
Copy link

@rivajunior rivajunior commented Nov 8, 2020

blacklist is racial offensive and can easely be changed by other terms as exclude or denylist.

I've choose exclude because I think it fits better than denylist in this context. But I can change it.

@zloirock
Copy link
Owner

@zloirock zloirock commented Nov 9, 2020

I don't think that blacklist is racial offensive - I can't imagine what kind of complexes a person should have in order to be offended by this. However, yes, for this case exclude sounds better and I could accept this PR. But it's a breaking change, so required a fallback to blacklist.

README.md Outdated
npm install --save core-js-pure@3.7.0
// bundled global version
# bundled global version

This comment has been minimized.

@zloirock

zloirock Nov 9, 2020
Owner

Why it's changed? Please, remove all changes unrelated to exclude from this PR.

@rivajunior rivajunior force-pushed the rivajunior:refactor/change-blacklist-term branch from a9343bb to aae7671 Nov 9, 2020
@rivajunior rivajunior force-pushed the rivajunior:refactor/change-blacklist-term branch from aae7671 to bbf0280 Nov 9, 2020
@@ -321,7 +321,7 @@ It does not work with some features. Also, if you change the default behaviour,

### Custom build

For some cases could be useful adding a blacklist of features or generation a polyfill for target engines. You could use [`core-js-builder`](/packages/core-js-builder) package for that.
For some cases could be useful adding a _exclude_ of features or generation a polyfill for target engines. You could use [`core-js-builder`](/packages/core-js-builder) package for that.

This comment has been minimized.

@zloirock

zloirock Nov 9, 2020
Owner

Please, rephrase into something more readable. The rest entries - too.

This comment has been minimized.

@rivajunior

rivajunior Nov 9, 2020
Author

@zloirock what do you think about the following?

For some cases could be useful generating a especific polyfill for target engines.

You can use core-js-builder package for include or exclude parts of core-js. And optionally generate a file from that.

@zloirock zloirock merged commit e3b7484 into zloirock:master Nov 24, 2020
zloirock added a commit that referenced this pull request Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.