CVE-2022-37704 - privilege escalation form amandabackup user to root -fix

[seetharaman-rajagopal]

Fixes done for security issue.
Add functions to validated the commandline options.
previously "rundump” application was not doing any option filtering. Now it does.
Using getopt() to filter the backlist option. (like -F)

[pcahyna]

You are missing { here.
Since the block below now has multiple statements, the else above matches only the first one
and validate_dump_option(argc, argv); is always executed. This breaks legitimate xfsdump usage, because it aborts when using the -F option.

[pcahyna]

You are missing } here.

[pcahyna]

This is unfortunately insufficient. dump has an undocumented obsolete option syntax where all options can be provided in the first argument together without a leading -, and their parameters (for options that take parameters) after. So

dump -B 1 -f foo -F bar baz

can also be (and is) specified as

dump BfF 1 foo bar baz

See the function obsolete() in dump/main.c.

[pcahyna]

validate_xfsdump_options() is also missing after the first dump_program = XFSDUMP; statement. See #205