Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Add QAZ Shield #130

Merged
merged 7 commits into from Aug 28, 2020
Merged

Conversation

tominabox1
Copy link
Contributor

@tominabox1 tominabox1 commented Aug 28, 2020

Add QAZ shield

@petejohanson petejohanson added enhancement New feature or request shields PRs and issues related to shields labels Aug 28, 2020
Copy link
Contributor

@petejohanson petejohanson left a comment

Thanks for the new shield! A few items that need tweaking.

CONFIG_LOG=y
CONFIG_ZMK_LOG_LEVEL_DBG=y

# Turn on USB CDC ACM device
CONFIG_USB=y
CONFIG_USB_DEVICE_STACK=y
CONFIG_USB_CDC_ACM=y
CONFIG_USB_CDC_ACM_RINGBUF_SIZE=1024
CONFIG_USB_CDC_ACM_DEVICE_NAME="CDC_ACM"
CONFIG_USB_CDC_ACM_DEVICE_COUNT=1

# Enable serial console
CONFIG_SERIAL=y
CONFIG_CONSOLE=y
CONFIG_UART_INTERRUPT_DRIVEN=y
CONFIG_UART_LINE_CTRL=y

# Enable USB UART, and set the console device
CONFIG_UART_CONSOLE=y
CONFIG_USB_UART_CONSOLE=y
CONFIG_UART_CONSOLE_ON_DEV_NAME="CDC_ACM_0"
CONFIG_USB_UART_DTR_WAIT=n
Copy link
Contributor

@petejohanson petejohanson Aug 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have not been turning on logging by default in these files, since it is a theoretically security concern, since it logs keystroke information. These should be removed for the version of this for in-tree use.

Copy link
Contributor Author

@tominabox1 tominabox1 Aug 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops forgot I had that in there

bindings = <&bootloader>, <&reset>, <&kp BKSP>;
};

num_spc: behavior_tap_hold2 {
Copy link
Contributor

@petejohanson petejohanson Aug 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tap hold is not in main, so this should not be in here. Once we merge that, this can be restored, but for now this should be in your personal user config keymap for this.

app/boards/shields/qaz/qaz.keymap Show resolved Hide resolved
chosen {
zmk,kscan = &kscan0;
zmk,matrix_transform = &default_transform;
zmk,underglow = &led_strip;
Copy link
Contributor

@petejohanson petejohanson Aug 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be added in the nice_nano overlay where the led_strip is defined. This will ensure this shield builds properly with other controllers like the BlueMicro840.

app/boards/shields/qaz/qaz.overlay Show resolved Hide resolved
@@ -0,0 +1,2 @@
config SHIELD_MY_BOARD
Copy link
Contributor

@petejohanson petejohanson Aug 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a copyright/license header. Thanks!

app/boards/shields/qaz/Kconfig.defconfig Show resolved Hide resolved
@tominabox1
Copy link
Contributor Author

tominabox1 commented Aug 28, 2020

Updated as requested. I removed RGB support. I have not been able to get it to work on my board as I believe we are using one of the low freq pins (P1.15) so may not be possible.

Copy link
Contributor

@petejohanson petejohanson left a comment

Thanks!

@petejohanson petejohanson merged commit 14d09e7 into zmkfirmware:main Aug 28, 2020
1 check passed
MangoIV pushed a commit to MangoIV/zmk that referenced this pull request Dec 18, 2020
tyalie pushed a commit to tyalie/zmk that referenced this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request shields PRs and issues related to shields
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants