Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hold-Tap implementation #146

Merged
merged 5 commits into from Sep 2, 2020
Merged

Conversation

okke-formsma
Copy link
Collaborator

@okke-formsma okke-formsma commented Sep 1, 2020

This merge implements the behavior discussed in #117. For some discussion see the previous PR #141

The tap-hold behavior will soak new position-events until it can make a decision to 'hold' or 'tap', after which all queued keycodes are bubbled.

We get three "flavors" of mod-taps: "hold-preferred" (default), "balanced" and "tap-preferred".

  • The hold-preferred is default as it gives the fastest response; as soon as another key is pressed, the hold functionality is enabled. (Or if the timer runs out)
  • The balanced behavior decides on hold if another key is pressed and released while the tap-hold was active (Or if the timer runs out)
  • The tap-preferred behavior only decides on hold if the timer runs out.

@okke-formsma

This comment has been minimized.

@okke-formsma okke-formsma force-pushed the hold-tap branch 2 times, most recently from 31d8a84 to 5a58b26 Compare Sep 1, 2020
Copy link
Contributor

@petejohanson petejohanson left a comment

Thanks for all the work on this! I haven't had a chance to test this, but I know others have with good success. A smattering of comments/notes on some changes needed.

app/dts/behaviors/mod_tap.dtsi Show resolved Hide resolved
app/dts/behaviors/homerow_tap.dtsi Outdated Show resolved Hide resolved
app/run-test-debug.sh Outdated Show resolved Hide resolved
app/include/zmk/event-manager.h Outdated Show resolved Hide resolved
app/tests/hold-tap/balanced/1/events.patterns Outdated Show resolved Hide resolved
docs/docs/behavior/hold-tap.md Outdated Show resolved Hide resolved
docs/docs/behavior/mod-tap.md Outdated Show resolved Hide resolved
app/src/behaviors/behavior_hold_tap.c Show resolved Hide resolved
app/src/behaviors/behavior_hold_tap.c Outdated Show resolved Hide resolved
app/src/behaviors/behavior_hold_tap.c Outdated Show resolved Hide resolved
@okke-formsma okke-formsma mentioned this pull request Sep 2, 2020
app/src/behaviors/behavior_hold_tap.c Outdated Show resolved Hide resolved
Copy link
Contributor

@petejohanson petejohanson left a comment

Few minor follow up.s

app/src/behaviors/behavior_hold_tap.c Outdated Show resolved Hide resolved
app/src/behaviors/behavior_hold_tap.c Outdated Show resolved Hide resolved
@okke-formsma okke-formsma requested a review from petejohanson Sep 2, 2020
Copy link
Contributor

@petejohanson petejohanson left a comment

Let's move forward for this. Thanks for all the time on this.

@petejohanson petejohanson merged commit 48a3729 into zmkfirmware:main Sep 2, 2020
1 check passed
MangoIV pushed a commit to MangoIV/zmk that referenced this pull request Dec 18, 2020
@benvallack
Copy link

benvallack commented Oct 8, 2021

How would I go about a tap-hold key that holds down ALT + CTRL + SHIFT when held and a different key when tapped?

Found the answer: &mt LC(LS(LALT)) SPC

tyalie pushed a commit to tyalie/zmk that referenced this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants