Cradio #224
Cradio #224
Conversation
Ok, both sides work as expected, need to write a keymap.
| # across A & B controllers, and STM32F303CCT6 can't enable | ||
| # interrutps for multiple controllers for the same "line" | ||
| # for the external interrupts. | ||
| config ZMK_KSCAN_GPIO_POLLING |
There was a problem hiding this comment.
Were you testing with proton-c controllers? If so, there's actually a way to provide board specific overrides for a given shield, you can see that in https://docs.zephyrproject.org/2.3.0/guides/porting/shields.html?highlight=shield#board-specific-shield-configuration
I would remove this from the "base" defconfig here, and put it in the proton-c specific one.
There was a problem hiding this comment.
I'm not clear what you mean here so i just deleted everything about config...
| @@ -0,0 +1,14 @@ | |||
|
|
|||
There was a problem hiding this comment.
Please add the standard ZMK header here, e.g.
# Copyright (c) 2020 The ZMK Contributors
# SPDX-License-Identifier: MIT
| @@ -0,0 +1,5 @@ | |||
| # Copyright (c) 2020 Pete Johanson | |||
There was a problem hiding this comment.
We're still working on fixing up existing boards, but please use the "single author file" version like so:
| # Copyright (c) 2020 Pete Johanson | |
| # Copyright (c) 2020 The ZMK Contributors |
There was a problem hiding this comment.
added
Copyright (c) 2020 The ZMK Contributors
SPDX-License-Identifier: MIT
.gitignore
Outdated
| @@ -4,3 +4,4 @@ | |||
| /tools | |||
| /zephyr | |||
| /build | |||
| **/.DS_Store | |||
There was a problem hiding this comment.
This sadly conflicts w/ main now. Can you revert this, then we can merge?
| @@ -0,0 +1,5 @@ | |||
| # Copyright (c) 2020 Pete Johanson | |||
There was a problem hiding this comment.
Ditto.
| # Copyright (c) 2020 Pete Johanson | |
| # Copyright (c) 2020 The ZMK Contributors |
There was a problem hiding this comment.
added# Copyright (c) 2020 The ZMK Contributors
SPDX-License-Identifier: MIT
|
|
||
| }; | ||
|
|
||
| &kscan0 { |
There was a problem hiding this comment.
This should be merged with the initial kscan0 definition above this.
There was a problem hiding this comment.
i've nudged this around and it seem to still compile...
There was a problem hiding this comment.
Maybe I wasn't clear, this should just something like:
kscan0: kscan {
input-gpios = <foo>;
};
Altogether, you don't need to define it further up, then reference it by "anchor" here again.
| config ZMK_KEYBOARD_NAME | ||
| default "cradio" | ||
|
|
||
| config ZMK_KSCAN_GPIO_POLLING |
There was a problem hiding this comment.
Since you opened this PR, this got refactored a bit, and the naming improved:
| config ZMK_KSCAN_GPIO_POLLING | |
| config ZMK_KSCAN_DIRECT_POLLING |
There was a problem hiding this comment.
gotcha, sorted, can't wait to try it.
| @@ -0,0 +1,6 @@ | |||
| /* | |||
| * Copyright (c) 2020 Pete Johanson | |||
There was a problem hiding this comment.
This is a duplicate now.
There was a problem hiding this comment.
modded to mirror corne overlay header
There was a problem hiding this comment.
| * Copyright (c) 2020 Pete Johanson | |
| * Copyright (c) 2020 The ZMK Contributors |
The Corne overlay header is wrong, and needs fixing, which has been done in another PR that's nearly in.
| @@ -0,0 +1,11 @@ | |||
| /* | |||
| * Copyright (c) 2020 Pete Johanson | |||
There was a problem hiding this comment.
modded to mirror corne overlay header
There was a problem hiding this comment.
| * Copyright (c) 2020 Pete Johanson | |
| * Copyright (c) 2020 The ZMK Contributors |
Ditto.
|
|
||
| }; | ||
|
|
||
| &kscan0 { |
There was a problem hiding this comment.
Maybe I wasn't clear, this should just something like:
kscan0: kscan {
input-gpios = <foo>;
};
Altogether, you don't need to define it further up, then reference it by "anchor" here again.
| @@ -0,0 +1,6 @@ | |||
| /* | |||
| * Copyright (c) 2020 Pete Johanson | |||
There was a problem hiding this comment.
| * Copyright (c) 2020 Pete Johanson | |
| * Copyright (c) 2020 The ZMK Contributors |
The Corne overlay header is wrong, and needs fixing, which has been done in another PR that's nearly in.
| @@ -0,0 +1,11 @@ | |||
| /* | |||
| * Copyright (c) 2020 Pete Johanson | |||
There was a problem hiding this comment.
| * Copyright (c) 2020 Pete Johanson | |
| * Copyright (c) 2020 The ZMK Contributors |
Ditto.
34 key keyboard with no diodes.